Code review comment for lp:~dave-cheney/juju-core/104-fix-lp-1298703

The attempt to merge lp:~dave-cheney/juju-core/104-fix-lp-1298703 into lp:juju-core failed. Below is the output from the failed tests.

ok launchpad.net/juju-core 0.031s
ok launchpad.net/juju-core/agent 0.632s
ok launchpad.net/juju-core/agent/mongo 0.535s
ok launchpad.net/juju-core/agent/tools 0.188s
ok launchpad.net/juju-core/bzr 5.134s
ok launchpad.net/juju-core/cert 2.503s
ok launchpad.net/juju-core/charm 0.425s
? launchpad.net/juju-core/charm/hooks [no test files]
? launchpad.net/juju-core/charm/testing [no test files]
ok launchpad.net/juju-core/cloudinit 0.033s
ok launchpad.net/juju-core/cloudinit/sshinit 0.759s
ok launchpad.net/juju-core/cmd 0.175s
ok launchpad.net/juju-core/cmd/charm-admin 0.746s
? launchpad.net/juju-core/cmd/charmd [no test files]
? launchpad.net/juju-core/cmd/charmload [no test files]
ok launchpad.net/juju-core/cmd/juju 200.275s
ok launchpad.net/juju-core/cmd/jujud 64.588s
ok launchpad.net/juju-core/cmd/plugins/juju-metadata 8.473s
? launchpad.net/juju-core/cmd/plugins/juju-restore [no test files]
ok launchpad.net/juju-core/cmd/plugins/local 0.141s
? launchpad.net/juju-core/cmd/plugins/local/juju-local [no test files]
ok launchpad.net/juju-core/constraints 0.022s
ok launchpad.net/juju-core/container 0.047s
ok launchpad.net/juju-core/container/factory 0.045s
ok launchpad.net/juju-core/container/kvm 0.275s
ok launchpad.net/juju-core/container/kvm/mock 0.051s
? launchpad.net/juju-core/container/kvm/testing [no test files]
ok launchpad.net/juju-core/container/lxc 4.307s
? launchpad.net/juju-core/container/lxc/mock [no test files]
? launchpad.net/juju-core/container/lxc/testing [no test files]
? launchpad.net/juju-core/container/testing [no test files]
ok launchpad.net/juju-core/downloader 5.235s
ok launchpad.net/juju-core/environs 2.062s
ok launchpad.net/juju-core/environs/bootstrap 11.014s
ok launchpad.net/juju-core/environs/cloudinit 0.498s
ok launchpad.net/juju-core/environs/config 1.721s
ok launchpad.net/juju-core/environs/configstore 0.032s
ok launchpad.net/juju-core/environs/filestorage 0.027s
ok launchpad.net/juju-core/environs/httpstorage 0.719s
ok launchpad.net/juju-core/environs/imagemetadata 0.421s
? launchpad.net/juju-core/environs/imagemetadata/testing [no test files]
ok launchpad.net/juju-core/environs/instances 0.043s
ok launchpad.net/juju-core/environs/jujutest 0.177s
ok launchpad.net/juju-core/environs/manual 10.618s
ok launchpad.net/juju-core/environs/simplestreams 0.319s
? launchpad.net/juju-core/environs/simplestreams/testing [no test files]
ok launchpad.net/juju-core/environs/sshstorage 0.938s
ok launchpad.net/juju-core/environs/storage 0.924s
ok launchpad.net/juju-core/environs/sync 43.345s
ok launchpad.net/juju-core/environs/testing 0.169s
ok launchpad.net/juju-core/environs/tools 4.716s
? launchpad.net/juju-core/environs/tools/testing [no test files]
ok launchpad.net/juju-core/errors 0.016s
ok launchpad.net/juju-core/instance 0.027s
? launchpad.net/juju-core/instance/testing [no test files]
ok launchpad.net/juju-core/juju 18.900s
ok launchpad.net/juju-core/juju/arch 0.014s
ok launchpad.net/juju-core/juju/osenv 0.015s
? launchpad.net/juju-core/juju/testing [no test files]
ok launchpad.net/juju-core/log 0.012s
ok launchpad.net/juju-core/log/syslog 0.047s
? launchpad.net/juju-core/log/syslog/testing [no test files]
ok launchpad.net/juju-core/names 0.025s
? launchpad.net/juju-core/provider [no test files]
? launchpad.net/juju-core/provider/all [no test files]
ok launchpad.net/juju-core/provider/azure 5.351s
ok launchpad.net/juju-core/provider/common 5.409s
ok launchpad.net/juju-core/provider/dummy 16.526s
ok launchpad.net/juju-core/provider/ec2 10.808s
ok launchpad.net/juju-core/provider/joyent 3.465s
ok launchpad.net/juju-core/provider/local 14.032s
ok launchpad.net/juju-core/provider/maas 12.386s
ok launchpad.net/juju-core/provider/manual 1.194s
ok launchpad.net/juju-core/provider/openstack 26.418s
ok launchpad.net/juju-core/replicaset 78.278s
ok launchpad.net/juju-core/rpc 0.079s
ok launchpad.net/juju-core/rpc/jsoncodec 0.029s
? launchpad.net/juju-core/rpc/rpcreflect [no test files]
ok launchpad.net/juju-core/schema 0.016s
ok launchpad.net/juju-core/state 85.453s
ok launchpad.net/juju-core/state/api 1.690s
ok launchpad.net/juju-core/state/api/agent 1.748s
? launchpad.net/juju-core/state/api/base [no test files]
ok launchpad.net/juju-core/state/api/charmrevisionupdater 1.313s
? launchpad.net/juju-core/state/api/common [no test files]
ok launchpad.net/juju-core/state/api/deployer 6.260s
ok launchpad.net/juju-core/state/api/environment 1.675s
ok launchpad.net/juju-core/state/api/firewaller 9.265s
ok launchpad.net/juju-core/state/api/keymanager 3.622s
ok launchpad.net/juju-core/state/api/keyupdater 2.257s
ok launchpad.net/juju-core/state/api/logger 1.808s
ok launchpad.net/juju-core/state/api/machiner 4.370s
ok launchpad.net/juju-core/state/api/params 0.029s
ok launchpad.net/juju-core/state/api/provisioner 9.607s
ok launchpad.net/juju-core/state/api/rsyslog 1.673s
? launchpad.net/juju-core/state/api/testing [no test files]
ok launchpad.net/juju-core/state/api/uniter 25.937s
ok launchpad.net/juju-core/state/api/upgrader 8.364s
ok launchpad.net/juju-core/state/api/usermanager 1.863s
ok launchpad.net/juju-core/state/api/watcher 2.930s
ok launchpad.net/juju-core/state/apiserver 11.817s
ok launchpad.net/juju-core/state/apiserver/agent 2.784s
ok launchpad.net/juju-core/state/apiserver/charmrevisionupdater 2.414s
? launchpad.net/juju-core/state/apiserver/charmrevisionupdater/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/client 43.908s
ok launchpad.net/juju-core/state/apiserver/common 2.206s
? launchpad.net/juju-core/state/apiserver/common/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/deployer 4.188s
ok launchpad.net/juju-core/state/apiserver/environment 1.424s
ok launchpad.net/juju-core/state/apiserver/firewaller 5.446s
ok launchpad.net/juju-core/state/apiserver/keymanager 4.649s
? launchpad.net/juju-core/state/apiserver/keymanager/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/keyupdater 2.585s
ok launchpad.net/juju-core/state/apiserver/logger 3.171s
ok launchpad.net/juju-core/state/apiserver/machine 2.679s
ok launchpad.net/juju-core/state/apiserver/provisioner 13.480s
ok launchpad.net/juju-core/state/apiserver/rsyslog 2.597s
? launchpad.net/juju-core/state/apiserver/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/uniter 17.999s
ok launchpad.net/juju-core/state/apiserver/upgrader 9.641s
ok launchpad.net/juju-core/state/apiserver/usermanager 1.804s
ok launchpad.net/juju-core/state/multiwatcher 0.608s
ok launchpad.net/juju-core/state/presence 6.294s
ok launchpad.net/juju-core/state/statecmd 1.606s
? launchpad.net/juju-core/state/testing [no test files]
ok launchpad.net/juju-core/state/watcher 5.137s
ok launchpad.net/juju-core/store 17.469s
ok launchpad.net/juju-core/testing 1.236s
ok launchpad.net/juju-core/testing/testbase 0.014s
ok launchpad.net/juju-core/thirdparty/pbkdf2 0.111s
ok launchpad.net/juju-core/tools 0.027s
ok launchpad.net/juju-core/upgrades 6.472s
ok launchpad.net/juju-core/upstart 1.061s
ok launchpad.net/juju-core/utils 1.997s
ok launchpad.net/juju-core/utils/exec 0.027s
ok launchpad.net/juju-core/utils/fslock 0.918s
ok launchpad.net/juju-core/utils/parallel 0.895s
ok launchpad.net/juju-core/utils/set 0.012s
ok launchpad.net/juju-core/utils/shell 0.031s
ok launchpad.net/juju-core/utils/ssh 16.877s
? launchpad.net/juju-core/utils/ssh/testing [no test files]
ok launchpad.net/juju-core/utils/tailer 0.929s
ok launchpad.net/juju-core/utils/voyeur 0.014s
ok launchpad.net/juju-core/utils/zip 0.086s
ok launchpad.net/juju-core/version 0.059s
ok launchpad.net/juju-core/worker 16.902s
ok launchpad.net/juju-core/worker/authenticationworker 2.778s
ok launchpad.net/juju-core/worker/charmrevisionworker 1.894s
ok launchpad.net/juju-core/worker/cleaner 1.203s
ok launchpad.net/juju-core/worker/deployer 3.157s
ok launchpad.net/juju-core/worker/firewaller 8.338s
ok launchpad.net/juju-core/worker/instancepoller 1.540s
ok launchpad.net/juju-core/worker/localstorage 0.050s
ok launchpad.net/juju-core/worker/logger 1.322s
ok launchpad.net/juju-core/worker/machineenvironmentworker 7.307s
ok launchpad.net/juju-core/worker/machiner 2.718s
ok launchpad.net/juju-core/worker/minunitsworker 1.211s
ok launchpad.net/juju-core/worker/peergrouper 1.432s
ok launchpad.net/juju-core/worker/provisioner 33.613s
ok launchpad.net/juju-core/worker/resumer 1.363s
ok launchpad.net/juju-core/worker/rsyslog 3.373s
ok launchpad.net/juju-core/worker/terminationworker 0.049s
ok launchpad.net/juju-core/worker/uniter 105.875s
ok launchpad.net/juju-core/worker/uniter/charm 2.475s
ok launchpad.net/juju-core/worker/uniter/debug 0.076s
ok launchpad.net/juju-core/worker/uniter/hook 0.013s
ok launchpad.net/juju-core/worker/uniter/jujuc 0.392s
ok launchpad.net/juju-core/worker/uniter/relation 1.272s
*** Test killed: ran too long (10m0s).
FAIL launchpad.net/juju-core/worker/upgrader 600.005s

warning: building out-of-date packages:
 launchpad.net/goamz/ec2/ec2test
 launchpad.net/goamz/s3/s3test
 launchpad.net/goose/testservices/hook
 launchpad.net/goose/testservices/identityservice
 launchpad.net/goose/testservices
 launchpad.net/goose/testservices/novaservice
 launchpad.net/goose/testservices/swiftservice
 launchpad.net/goose/testservices/openstackservice
installing these packages with 'go test -i ./...' will speed future tests.