Code review comment for lp:~dave-cheney/juju-core/104-fix-lp-1298703

The attempt to merge lp:~dave-cheney/juju-core/104-fix-lp-1298703 into lp:juju-core failed. Below is the output from the failed tests.

ok launchpad.net/juju-core 0.013s
ok launchpad.net/juju-core/agent 1.097s
ok launchpad.net/juju-core/agent/mongo 0.533s
ok launchpad.net/juju-core/agent/tools 0.211s
ok launchpad.net/juju-core/bzr 5.350s
ok launchpad.net/juju-core/cert 2.250s
ok launchpad.net/juju-core/charm 0.419s
? launchpad.net/juju-core/charm/hooks [no test files]
? launchpad.net/juju-core/charm/testing [no test files]
ok launchpad.net/juju-core/cloudinit 0.027s
ok launchpad.net/juju-core/cloudinit/sshinit 0.797s
ok launchpad.net/juju-core/cmd 0.167s
ok launchpad.net/juju-core/cmd/charm-admin 0.751s
? launchpad.net/juju-core/cmd/charmd [no test files]
? launchpad.net/juju-core/cmd/charmload [no test files]
ok launchpad.net/juju-core/cmd/juju 198.681s
ok launchpad.net/juju-core/cmd/jujud 64.359s
ok launchpad.net/juju-core/cmd/plugins/juju-metadata 6.749s
? launchpad.net/juju-core/cmd/plugins/juju-restore [no test files]
ok launchpad.net/juju-core/cmd/plugins/local 0.214s
? launchpad.net/juju-core/cmd/plugins/local/juju-local [no test files]
ok launchpad.net/juju-core/constraints 0.020s
ok launchpad.net/juju-core/container 0.051s
ok launchpad.net/juju-core/container/factory 0.053s
ok launchpad.net/juju-core/container/kvm 0.180s
ok launchpad.net/juju-core/container/kvm/mock 0.039s
? launchpad.net/juju-core/container/kvm/testing [no test files]
ok launchpad.net/juju-core/container/lxc 4.273s
? launchpad.net/juju-core/container/lxc/mock [no test files]
? launchpad.net/juju-core/container/lxc/testing [no test files]
? launchpad.net/juju-core/container/testing [no test files]
ok launchpad.net/juju-core/downloader 5.229s
ok launchpad.net/juju-core/environs 2.294s
ok launchpad.net/juju-core/environs/bootstrap 10.226s
ok launchpad.net/juju-core/environs/cloudinit 0.464s
ok launchpad.net/juju-core/environs/config 2.395s
ok launchpad.net/juju-core/environs/configstore 0.026s
ok launchpad.net/juju-core/environs/filestorage 0.027s
ok launchpad.net/juju-core/environs/httpstorage 0.682s
ok launchpad.net/juju-core/environs/imagemetadata 0.432s
? launchpad.net/juju-core/environs/imagemetadata/testing [no test files]
ok launchpad.net/juju-core/environs/instances 0.044s
ok launchpad.net/juju-core/environs/jujutest 0.152s
ok launchpad.net/juju-core/environs/manual 11.840s
ok launchpad.net/juju-core/environs/simplestreams 0.289s
? launchpad.net/juju-core/environs/simplestreams/testing [no test files]
ok launchpad.net/juju-core/environs/sshstorage 0.985s
ok launchpad.net/juju-core/environs/storage 0.897s
ok launchpad.net/juju-core/environs/sync 44.217s
ok launchpad.net/juju-core/environs/testing 0.133s
ok launchpad.net/juju-core/environs/tools 4.917s
? launchpad.net/juju-core/environs/tools/testing [no test files]
ok launchpad.net/juju-core/errors 0.011s
ok launchpad.net/juju-core/instance 0.017s
? launchpad.net/juju-core/instance/testing [no test files]
ok launchpad.net/juju-core/juju 19.130s
ok launchpad.net/juju-core/juju/arch 0.022s
ok launchpad.net/juju-core/juju/osenv 0.015s
? launchpad.net/juju-core/juju/testing [no test files]
ok launchpad.net/juju-core/log 0.012s
ok launchpad.net/juju-core/log/syslog 0.045s
? launchpad.net/juju-core/log/syslog/testing [no test files]
ok launchpad.net/juju-core/names 0.020s
? launchpad.net/juju-core/provider [no test files]
? launchpad.net/juju-core/provider/all [no test files]
ok launchpad.net/juju-core/provider/azure 5.592s
ok launchpad.net/juju-core/provider/common 4.858s
ok launchpad.net/juju-core/provider/dummy 16.903s
ok launchpad.net/juju-core/provider/ec2 12.883s
ok launchpad.net/juju-core/provider/joyent 3.814s
ok launchpad.net/juju-core/provider/local 13.457s
ok launchpad.net/juju-core/provider/maas 12.938s
ok launchpad.net/juju-core/provider/manual 1.159s
ok launchpad.net/juju-core/provider/openstack 27.113s
ok launchpad.net/juju-core/replicaset 60.857s
ok launchpad.net/juju-core/rpc 0.074s
ok launchpad.net/juju-core/rpc/jsoncodec 0.023s
? launchpad.net/juju-core/rpc/rpcreflect [no test files]
ok launchpad.net/juju-core/schema 0.022s
ok launchpad.net/juju-core/state 85.390s
ok launchpad.net/juju-core/state/api 1.604s
ok launchpad.net/juju-core/state/api/agent 1.733s
? launchpad.net/juju-core/state/api/base [no test files]
ok launchpad.net/juju-core/state/api/charmrevisionupdater 1.264s
? launchpad.net/juju-core/state/api/common [no test files]
ok launchpad.net/juju-core/state/api/deployer 6.278s
ok launchpad.net/juju-core/state/api/environment 1.717s
ok launchpad.net/juju-core/state/api/firewaller 9.393s
ok launchpad.net/juju-core/state/api/keymanager 3.611s
ok launchpad.net/juju-core/state/api/keyupdater 2.293s
ok launchpad.net/juju-core/state/api/logger 2.011s
ok launchpad.net/juju-core/state/api/machiner 4.517s
ok launchpad.net/juju-core/state/api/params 0.029s
ok launchpad.net/juju-core/state/api/provisioner 9.543s
ok launchpad.net/juju-core/state/api/rsyslog 1.682s
? launchpad.net/juju-core/state/api/testing [no test files]
ok launchpad.net/juju-core/state/api/uniter 25.990s
ok launchpad.net/juju-core/state/api/upgrader 8.576s
ok launchpad.net/juju-core/state/api/usermanager 1.762s
ok launchpad.net/juju-core/state/api/watcher 2.727s
ok launchpad.net/juju-core/state/apiserver 11.967s
ok launchpad.net/juju-core/state/apiserver/agent 2.763s
ok launchpad.net/juju-core/state/apiserver/charmrevisionupdater 2.315s
? launchpad.net/juju-core/state/apiserver/charmrevisionupdater/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/client 44.722s
ok launchpad.net/juju-core/state/apiserver/common 2.256s
? launchpad.net/juju-core/state/apiserver/common/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/deployer 4.164s
ok launchpad.net/juju-core/state/apiserver/environment 1.341s
ok launchpad.net/juju-core/state/apiserver/firewaller 5.520s
ok launchpad.net/juju-core/state/apiserver/keymanager 4.718s
? launchpad.net/juju-core/state/apiserver/keymanager/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/keyupdater 2.638s
ok launchpad.net/juju-core/state/apiserver/logger 3.091s
ok launchpad.net/juju-core/state/apiserver/machine 2.595s
ok launchpad.net/juju-core/state/apiserver/provisioner 12.653s
ok launchpad.net/juju-core/state/apiserver/rsyslog 2.517s
? launchpad.net/juju-core/state/apiserver/testing [no test files]
ok launchpad.net/juju-core/state/apiserver/uniter 17.954s
ok launchpad.net/juju-core/state/apiserver/upgrader 9.274s
ok launchpad.net/juju-core/state/apiserver/usermanager 1.879s
ok launchpad.net/juju-core/state/multiwatcher 0.628s
ok launchpad.net/juju-core/state/presence 6.363s
ok launchpad.net/juju-core/state/statecmd 1.599s
? launchpad.net/juju-core/state/testing [no test files]
ok launchpad.net/juju-core/state/watcher 4.996s
ok launchpad.net/juju-core/store 17.907s
ok launchpad.net/juju-core/testing 1.288s
ok launchpad.net/juju-core/testing/testbase 0.014s
ok launchpad.net/juju-core/thirdparty/pbkdf2 0.125s
ok launchpad.net/juju-core/tools 0.016s
ok launchpad.net/juju-core/upgrades 9.059s
ok launchpad.net/juju-core/upstart 1.008s
ok launchpad.net/juju-core/utils 2.053s
ok launchpad.net/juju-core/utils/exec 0.030s
ok launchpad.net/juju-core/utils/fslock 0.959s
ok launchpad.net/juju-core/utils/parallel 0.879s
ok launchpad.net/juju-core/utils/set 0.012s
ok launchpad.net/juju-core/utils/shell 0.038s
ok launchpad.net/juju-core/utils/ssh 21.543s
? launchpad.net/juju-core/utils/ssh/testing [no test files]
ok launchpad.net/juju-core/utils/tailer 0.948s
ok launchpad.net/juju-core/utils/voyeur 0.014s
ok launchpad.net/juju-core/utils/zip 0.087s
ok launchpad.net/juju-core/version 0.051s
ok launchpad.net/juju-core/worker 16.925s
ok launchpad.net/juju-core/worker/authenticationworker 2.663s
ok launchpad.net/juju-core/worker/charmrevisionworker 1.944s
ok launchpad.net/juju-core/worker/cleaner 1.114s
ok launchpad.net/juju-core/worker/deployer 8.179s
ok launchpad.net/juju-core/worker/firewaller 8.353s
ok launchpad.net/juju-core/worker/instancepoller 1.544s
ok launchpad.net/juju-core/worker/localstorage 0.042s
ok launchpad.net/juju-core/worker/logger 1.404s
ok launchpad.net/juju-core/worker/machineenvironmentworker 7.207s
ok launchpad.net/juju-core/worker/machiner 12.342s
ok launchpad.net/juju-core/worker/minunitsworker 1.246s
ok launchpad.net/juju-core/worker/peergrouper 1.525s
ok launchpad.net/juju-core/worker/provisioner 33.422s
ok launchpad.net/juju-core/worker/resumer 1.394s
ok launchpad.net/juju-core/worker/rsyslog 3.512s
ok launchpad.net/juju-core/worker/terminationworker 0.049s
ok launchpad.net/juju-core/worker/uniter 105.491s
ok launchpad.net/juju-core/worker/uniter/charm 2.480s
ok launchpad.net/juju-core/worker/uniter/debug 0.082s
ok launchpad.net/juju-core/worker/uniter/hook 0.018s
ok launchpad.net/juju-core/worker/uniter/jujuc 0.394s
ok launchpad.net/juju-core/worker/uniter/relation 1.269s
*** Test killed: ran too long (10m0s).
FAIL launchpad.net/juju-core/worker/upgrader 600.009s

warning: building out-of-date packages:
 launchpad.net/goamz/ec2/ec2test
 launchpad.net/goamz/s3/s3test
 launchpad.net/goose/testservices/hook
 launchpad.net/goose/testservices/identityservice
 launchpad.net/goose/testservices
 launchpad.net/goose/testservices/novaservice
 launchpad.net/goose/testservices/swiftservice
 launchpad.net/goose/testservices/openstackservice
installing these packages with 'go test -i ./...' will speed future tests.