Code review comment for lp:~dave-cheney/juju-core/104-fix-lp-1298703

Revision history for this message
Andrew Wilkins (axwalk) wrote :

On 2014/03/28 04:42:14, dfc wrote:
> Please take a look.

LGTM

+1 to moving NewAddress(es)

There is one non-test place where NewAddress is used, and in that case
it legitimately does not know the address's scope. It would be good to
make that explicit anyhow.

https://codereview.appspot.com/81720043/

« Back to merge proposal