Code review comment for lp:~dave-cheney/juju-core/052-environs-ec2-always-request-public-tools-from-us-east-1

Revision history for this message
John A Meinel (jameinel) wrote :

Seems ok. I'm not sure if having a configurable "grab the tools from
this region" is better than providing the tools in all regions. If this
is the best way forward, than LGTM.

https://codereview.appspot.com/6843112/diff/2001/environs/ec2/ec2.go
File environs/ec2/ec2.go (left):

https://codereview.appspot.com/6843112/diff/2001/environs/ec2/ec2.go#oldcode162
environs/ec2/ec2.go:162: }
It seems like if you've connected you might want to reuse s3Unlocked if
region == publicBucketRegion.

Beyond that, having to access us-east-1 from outside of it means paying
bandwidth charges, etc. Is it worthwhile to try and put the tools on all
regions?

https://codereview.appspot.com/6843112/

« Back to merge proposal