The change LGTM, but there are some small questions.
1) If you're changing the service to return 409, shouldn't there be a
corresponding client-side change that says "oh 409, that means it
already exists and I should just treat it as a duplicate".
2) Should we have something more like:
s.emulate = "us-east-1"
Rather than a simple boolean s.emulateUSEast1? I'm thinking that
eventually we may find that USEast2 acts differently from USWest, vs
Asia, etc.
I realize that us-east-1 is the most tested at this point, but it does
seem like you want more than 1 bit of info for the parametrization of
the test server.
The change LGTM, but there are some small questions.
1) If you're changing the service to return 409, shouldn't there be a
corresponding client-side change that says "oh 409, that means it
already exists and I should just treat it as a duplicate".
2) Should we have something more like:
s.emulate = "us-east-1"
Rather than a simple boolean s.emulateUSEast1? I'm thinking that
eventually we may find that USEast2 acts differently from USWest, vs
Asia, etc.
I realize that us-east-1 is the most tested at this point, but it does
seem like you want more than 1 bit of info for the parametrization of
the test server.
https:/ /codereview. appspot. com/6901061/