Merge lp:~dave-aitken/listen/listen-experimental into lp:listen

Proposed by Dave Aitken
Status: Merged
Merged at revision: 1123
Proposed branch: lp:~dave-aitken/listen/listen-experimental
Merge into: lp:listen
Diff against target: None lines
To merge this branch: bzr merge lp:~dave-aitken/listen/listen-experimental
Reviewer Review Type Date Requested Status
Listen Developers Pending
Review via email: mp+6420@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Dave Aitken (dave-aitken) wrote :

Tidied up a couple of tiny notification issues:
-Fixed track duration on mouseover always showing 00:00
-Shortened the title so it doesn't spill over onto 2 lines in new notify-osd in Ubuntu Jaunty
-Increased the size of the image sent to notification if type is notify-osd, this improves appearance with the scaling used by notify-osd.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/widget/notify.py'
--- src/widget/notify.py 2009-04-06 23:06:16 +0000
+++ src/widget/notify.py 2009-05-10 23:38:53 +0000
@@ -42,7 +42,7 @@
42 timeout = 1000042 timeout = 10000
43 current_song = None43 current_song = None
44 dbus_notify = None 44 dbus_notify = None
45 title = "\xe2\x99\xaa "+_("Listen now playing")+" \xe2\x99\xaa"45 title = "\xe2\x99\xaa "+_("Now playing")
46 actions = []46 actions = []
47 hints = []47 hints = []
48 last_id = 048 last_id = 0
@@ -104,7 +104,7 @@
104 text.append("<i>"+song.get_str("artist",True)+"</i>")104 text.append("<i>"+song.get_str("artist",True)+"</i>")
105 if song.get("album"):105 if song.get("album"):
106 text.append(song.get_str("album",True))106 text.append(song.get_str("album",True))
107 text.append(utils.duration_to_string(value,"00:00")+" "+_("of")+" "+utils.duration_to_string(Player.get_length(),"00:00"))107 text.append(utils.duration_to_string(value,"00:00")+" "+_("of")+" "+utils.duration_to_string(Player.get_length(),"00:00",1))
108 108
109 text = "\n".join(text)109 text = "\n".join(text)
110 else:110 else:
@@ -158,7 +158,11 @@
158 icon = "" 158 icon = ""
159 if song:159 if song:
160 try:160 try:
161 pixbuf = CoverManager.get_pixbuf_from_song(song, 40, 40, False)161 if self.notify_server_info[0] == "notify-osd":
162 #Larger image to improve image quality when scaled by notify-osd
163 pixbuf = CoverManager.get_pixbuf_from_song(song, 256, 256, False)
164 else:
165 pixbuf = CoverManager.get_pixbuf_from_song(song, 40, 40, False)
162 w, h = pixbuf.get_width(), pixbuf.get_height()166 w, h = pixbuf.get_width(), pixbuf.get_height()
163 line = gtk.gdk.Pixbuf(gtk.gdk.COLORSPACE_RGB, True, 8, w + 2, h + 2)167 line = gtk.gdk.Pixbuf(gtk.gdk.COLORSPACE_RGB, True, 8, w + 2, h + 2)
164 line.fill(0x000000ff)168 line.fill(0x000000ff)

Subscribers

People subscribed via source and target branches

to all changes: