Merge lp:~dave-aitken/listen/listen-experimental into lp:listen

Proposed by Dave Aitken
Status: Merged
Merged at revision: 1123
Proposed branch: lp:~dave-aitken/listen/listen-experimental
Merge into: lp:listen
Diff against target: None lines
To merge this branch: bzr merge lp:~dave-aitken/listen/listen-experimental
Reviewer Review Type Date Requested Status
Listen Developers Pending
Review via email: mp+6420@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Dave Aitken (dave-aitken) wrote :

Tidied up a couple of tiny notification issues:
-Fixed track duration on mouseover always showing 00:00
-Shortened the title so it doesn't spill over onto 2 lines in new notify-osd in Ubuntu Jaunty
-Increased the size of the image sent to notification if type is notify-osd, this improves appearance with the scaling used by notify-osd.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/widget/notify.py'
2--- src/widget/notify.py 2009-04-06 23:06:16 +0000
3+++ src/widget/notify.py 2009-05-10 23:38:53 +0000
4@@ -42,7 +42,7 @@
5 timeout = 10000
6 current_song = None
7 dbus_notify = None
8- title = "\xe2\x99\xaa "+_("Listen now playing")+" \xe2\x99\xaa"
9+ title = "\xe2\x99\xaa "+_("Now playing")
10 actions = []
11 hints = []
12 last_id = 0
13@@ -104,7 +104,7 @@
14 text.append("<i>"+song.get_str("artist",True)+"</i>")
15 if song.get("album"):
16 text.append(song.get_str("album",True))
17- text.append(utils.duration_to_string(value,"00:00")+" "+_("of")+" "+utils.duration_to_string(Player.get_length(),"00:00"))
18+ text.append(utils.duration_to_string(value,"00:00")+" "+_("of")+" "+utils.duration_to_string(Player.get_length(),"00:00",1))
19
20 text = "\n".join(text)
21 else:
22@@ -158,7 +158,11 @@
23 icon = ""
24 if song:
25 try:
26- pixbuf = CoverManager.get_pixbuf_from_song(song, 40, 40, False)
27+ if self.notify_server_info[0] == "notify-osd":
28+ #Larger image to improve image quality when scaled by notify-osd
29+ pixbuf = CoverManager.get_pixbuf_from_song(song, 256, 256, False)
30+ else:
31+ pixbuf = CoverManager.get_pixbuf_from_song(song, 40, 40, False)
32 w, h = pixbuf.get_width(), pixbuf.get_height()
33 line = gtk.gdk.Pixbuf(gtk.gdk.COLORSPACE_RGB, True, 8, w + 2, h + 2)
34 line.fill(0x000000ff)

Subscribers

People subscribed via source and target branches

to all changes: