Code review comment for ~dashmage/charm-sysconfig:bug-2012581/inherit-existing-kernel-params

Revision history for this message
JamesLin (jneo8) wrote (last edit ):

> There seems to be unit tests already for the `update_grub_file` function [1]. Would I need to add something additionally to test for the change made in the template file?

The unit test currently doesn't cover the bug case and it should be.

review: Needs Fixing

« Back to merge proposal