Code review comment for ~dashmage/charm-sysconfig:bug-2012581/inherit-existing-kernel-params
Revision history for this message
| Ashley James (dashmage) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Got feedback from @mfo who implemented the initial logic in the grub template file:
```
It looks like that MR is good.
AFAICT it
1) fixes the case I had wrong (do not erase $GRUB... if charm config option is not set), and
2) also addresses the case there are MAAS kernel options.
I haven't done any testing (I know you would / already have, for both issues), but it looks good from what I see.
```