Code review comment for lp:~darrylyeo/ubuntu-html5-theme/ubuntu-html5-theme
Revision history for this message
| Darryl Yeo (darrylyeo) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
Removed the header.
What color should it be? The $ubuntu_orange used already looks the same as the color in the QML version.
Unless I'm mistaken, the Color example in the QML version reads "Call".
The icon set doesn't come with white versions, so I'll use a CSS filter as a workaround.
> A few comments:
>
> - could you remove the <header> in buttons.html ?
> - could you fix the color which shouldn't be orange?
> - could you make the text for the Color example the same as the qml one?
> - could you tweak the color for the "call" icon to match the qml one?