Code review comment for ~darren-birkett/cloud-init:fix-infiniband-1847114

Revision history for this message
Ryan Harper (raharper) wrote :

Thanks for looking at this. I'd like to get this plumbed into the unittests for network generation ( tests/unittests/test_net.py ); I suggest adding this to the 'all' scenario, update the yaml to include the IB interface:

@@ -1456,6 +1476,12 @@ pre-down route del -net 10.0.0.0/8 gw 11.0.0.1 metric 3 || true
                   vlan_id: 200
                   subnets:
                       - type: dhcp4
+ # An Infiniband
+ - type: infiniband
+ name: ib0
+ mac_address: 00:11:22:33:44:56
+ subnets:
+ - type: dhcp4

And then fix up the expected eni and sysconfig output; lastly this will need an update to handle the convertion of v1 with type: infiniband to v2 where the type: infiniband will be converted to an ethernet type.

review: Needs Fixing

« Back to merge proposal