Merge lp:~darkxst/ubuntu/saucy/gnome-shell/lp1219188 into lp:ubuntu/saucy/gnome-shell

Proposed by Tim Lunn
Status: Merged
Merged at revision: 89
Proposed branch: lp:~darkxst/ubuntu/saucy/gnome-shell/lp1219188
Merge into: lp:ubuntu/saucy/gnome-shell
Diff against target: 150 lines (+120/-0)
5 files modified
debian/changelog (+9/-0)
debian/patches/git_background_schema.patch (+57/-0)
debian/patches/git_fix_calendar_wrapping.patch (+24/-0)
debian/patches/git_use_screensaver_bg.patch (+27/-0)
debian/patches/series (+3/-0)
To merge this branch: bzr merge lp:~darkxst/ubuntu/saucy/gnome-shell/lp1219188
Reviewer Review Type Date Requested Status
Jeremy Bícha Approve
Ubuntu branches Pending
Review via email: mp+183319@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jeremy Bícha (jbicha) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-07-31 21:29:20 +0000
+++ debian/changelog 2013-08-31 11:09:17 +0000
@@ -1,3 +1,12 @@
1gnome-shell (3.8.4-0ubuntu2) UNRELEASED; urgency=low
2
3 * debian/patches:
4 - git_fix_calendar_wrapping.patch: fixes wrapping of long calender events
5 - git_background_schema.patch, git_use_screensaver_bg.patch: git patches
6 to allow using seperate bg for lock screen (LP: #1219188)
7
8 -- Tim Lunn <tim@feathertop.org> Sat, 31 Aug 2013 21:07:20 +1000
9
1gnome-shell (3.8.4-0ubuntu1) saucy; urgency=low10gnome-shell (3.8.4-0ubuntu1) saucy; urgency=low
211
3 * New upstream release.12 * New upstream release.
413
=== added file 'debian/patches/git_background_schema.patch'
--- debian/patches/git_background_schema.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/git_background_schema.patch 2013-08-31 11:09:17 +0000
@@ -0,0 +1,57 @@
1From 4413f816e6016e3759e7e0b2d8188ee62aa1ab6a Mon Sep 17 00:00:00 2001
2From: Giovanni Campagna <gcampagna@src.gnome.org>
3Date: Mon, 19 Aug 2013 22:48:56 +0000
4Subject: Background: allow passing the settings schema from outside
5
6This way it is possible to use different settings for different
7backgrounds.
8
9https://bugzilla.gnome.org/show_bug.cgi?id=688210
10---
11diff --git a/js/ui/background.js b/js/ui/background.js
12index 1d9ab7c..246060a 100644
13--- a/js/ui/background.js
14+++ b/js/ui/background.js
15@@ -295,14 +295,15 @@ const Background = new Lang.Class({
16 _init: function(params) {
17 params = Params.parse(params, { monitorIndex: 0,
18 layoutManager: Main.layoutManager,
19- effects: Meta.BackgroundEffects.NONE });
20+ effects: Meta.BackgroundEffects.NONE,
21+ settings: null });
22 this.actor = new Meta.BackgroundGroup();
23 this.actor._delegate = this;
24
25 this._destroySignalId = this.actor.connect('destroy',
26 Lang.bind(this, this._destroy));
27
28- this._settings = new Gio.Settings({ schema: BACKGROUND_SCHEMA });
29+ this._settings = params.settings;
30 this._monitorIndex = params.monitorIndex;
31 this._layoutManager = params.layoutManager;
32 this._effects = params.effects;
33@@ -716,8 +717,10 @@ const BackgroundManager = new Lang.Class({
34 layoutManager: Main.layoutManager,
35 monitorIndex: null,
36 effects: Meta.BackgroundEffects.NONE,
37- controlPosition: true });
38+ controlPosition: true,
39+ settingsSchema: BACKGROUND_SCHEMA });
40
41+ this._settings = new Gio.Settings({ schema: params.settingsSchema });
42 this._container = params.container;
43 this._layoutManager = params.layoutManager;
44 this._effects = params.effects;
45@@ -776,7 +779,8 @@ const BackgroundManager = new Lang.Class({
46 _createBackground: function() {
47 let background = new Background({ monitorIndex: this._monitorIndex,
48 layoutManager: this._layoutManager,
49- effects: this._effects });
50+ effects: this._effects,
51+ settings: this._settings });
52 this._container.add_child(background.actor);
53
54 let monitor = this._layoutManager.monitors[this._monitorIndex];
55--
56cgit v0.9.2
57
058
=== added file 'debian/patches/git_fix_calendar_wrapping.patch'
--- debian/patches/git_fix_calendar_wrapping.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/git_fix_calendar_wrapping.patch 2013-08-31 11:09:17 +0000
@@ -0,0 +1,24 @@
1From cb45a38838eb441d4d3184560263ace5cc79057b Mon Sep 17 00:00:00 2001
2From: Florian Müllner <fmuellner@gnome.org>
3Date: Tue, 09 Jul 2013 17:59:06 +0000
4Subject: calendar: Fix line-wrapping of calendar events
5
6Commit 929636ebd0b8f428 broke line-wrapping of longish calendar events,
7add back the required CSS width.
8
9https://bugzilla.gnome.org/show_bug.cgi?id=703893
10---
11--- a/data/theme/gnome-shell.css
12+++ b/data/theme/gnome-shell.css
13@@ -1153,6 +1153,11 @@
14 min-width: 320px;
15 }
16
17+#calendarArea {
18+ /* this is the total width of the popup */
19+ max-width: 720px;
20+}
21+
22 .calendar-vertical-separator {
23 -stipple-width: 1px;
24 -stipple-color: #505050;
025
=== added file 'debian/patches/git_use_screensaver_bg.patch'
--- debian/patches/git_use_screensaver_bg.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/git_use_screensaver_bg.patch 2013-08-31 11:09:17 +0000
@@ -0,0 +1,27 @@
1From fdc08325065d464ea05e669d6f2a4889fe0b1d58 Mon Sep 17 00:00:00 2001
2From: Giovanni Campagna <gcampagna@src.gnome.org>
3Date: Mon, 19 Aug 2013 22:51:34 +0000
4Subject: ScreenShield: use the screensaver background
5
6Now that that's configurable in the control center, we should
7use the appropriate background here.
8
9https://bugzilla.gnome.org/show_bug.cgi?id=688210
10---
11diff --git a/js/ui/screenShield.js b/js/ui/screenShield.js
12index f375735..942f3eb 100644
13--- a/js/ui/screenShield.js
14+++ b/js/ui/screenShield.js
15@@ -599,7 +599,8 @@ const ScreenShield = new Lang.Class({
16
17 let bgManager = new Background.BackgroundManager({ container: widget,
18 monitorIndex: monitorIndex,
19- controlPosition: false });
20+ controlPosition: false,
21+ settingsSchema: SCREENSAVER_SCHEMA });
22
23 this._bgManagers.push(bgManager);
24
25--
26cgit v0.9.2
27
028
=== modified file 'debian/patches/series'
--- debian/patches/series 2013-07-31 21:29:20 +0000
+++ debian/patches/series 2013-08-31 11:09:17 +0000
@@ -10,3 +10,6 @@
10revert-power-dbus-name-update.patch10revert-power-dbus-name-update.patch
11revert-disable-periodic-gc.patch11revert-disable-periodic-gc.patch
12git_gjs_api_change.patch12git_gjs_api_change.patch
13git_fix_calendar_wrapping.patch
14git_background_schema.patch
15git_use_screensaver_bg.patch

Subscribers

People subscribed via source and target branches

to all changes: