Merge lp:~darkxst/ubuntu/quantal/gui-ufw/lp1071915 into lp:ubuntu/quantal/gui-ufw

Proposed by Tim Lunn
Status: Merged
Merge reported by: Stéphane Graber
Merged at revision: not available
Proposed branch: lp:~darkxst/ubuntu/quantal/gui-ufw/lp1071915
Merge into: lp:ubuntu/quantal/gui-ufw
Diff against target: 25 lines (+7/-2)
2 files modified
debian/changelog (+6/-0)
gufw.desktop.in (+1/-2)
To merge this branch: bzr merge lp:~darkxst/ubuntu/quantal/gui-ufw/lp1071915
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Needs Fixing
Ubuntu branches Pending
Review via email: mp+131696@code.launchpad.net
To post a comment you must log in.
39. By Tim Lunn

remove OnShowIn line

40. By Tim Lunn

Move icon from other to system

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Hey, see my comment on https://code.launchpad.net/~darkxst/ubuntu/raring/gui-ufw/lp1071915/+merge/135834 as raring needs fixing first :)

However, I think this OnlyShowIn=Unity was set for a purpose, maybe you should check with upstream if that's what they wanted really?

If not, we can remove it (but not with an inline patch like here, but rather with a distro-patch/quilt patch)

Marking as needs fixing for now

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2012-06-09 20:56:56 +0000
+++ debian/changelog 2012-11-06 06:09:19 +0000
@@ -1,3 +1,9 @@
1gui-ufw (12.10.0-0ubuntu2) quantal-proposed; urgency=low
2
3 * Set to display in GNOME (LP: #1071915)
4
5 -- Tim Lunn <tim@feathertop.org> Sat, 27 Oct 2012 08:31:44 +1100
6
1gui-ufw (12.10.0-0ubuntu1) quantal; urgency=low7gui-ufw (12.10.0-0ubuntu1) quantal; urgency=low
28
3 * New upstream release (LP: #911383, #925793).9 * New upstream release (LP: #911383, #925793).
410
=== modified file 'gufw.desktop.in'
--- gufw.desktop.in 2012-06-09 20:56:56 +0000
+++ gufw.desktop.in 2012-11-06 06:09:19 +0000
@@ -72,6 +72,5 @@
72Comment[ast]=Permite configurar el tornafuéu ufw72Comment[ast]=Permite configurar el tornafuéu ufw
73Comment[ar]=يسٌمح لك بإعداد الجدار الناري UFW73Comment[ar]=يسٌمح لك بإعداد الجدار الناري UFW
74Icon=gufw.png74Icon=gufw.png
75Categories=System;Settings;X-GNOME-Settings-Panel;75Categories=System;Settings;X-GNOME-Settings-Panel;X-GNOME-SystemSettings;
76OnlyShowIn=Unity;
77X-GNOME-Settings-Panel=gufw.png76X-GNOME-Settings-Panel=gufw.png

Subscribers

People subscribed via source and target branches

to all changes: