Merge lp:~darkxst/gnome-terminal/shell-search into lp:~ubuntu-desktop/gnome-terminal/ubuntu

Proposed by Tim Lunn
Status: Merged
Merged at revision: 138
Proposed branch: lp:~darkxst/gnome-terminal/shell-search
Merge into: lp:~ubuntu-desktop/gnome-terminal/ubuntu
Diff against target: 190 lines (+149/-2)
5 files modified
debian/changelog (+9/-0)
debian/gnome-terminal-data.install (+1/-1)
debian/patches/gnome-shell_search_provider.patch (+137/-0)
debian/patches/series (+1/-0)
debian/rules (+1/-1)
To merge this branch: bzr merge lp:~darkxst/gnome-terminal/shell-search
Reviewer Review Type Date Requested Status
Ubuntu Desktop Pending
Review via email: mp+238514@code.launchpad.net

Description of the change

We want the gnome-shell search provider to be built. Rather than requiring a build-dep on gnome-shell, this adds a local copy of the org.gnome.ShellSearchProvider2.xml interface

To post a comment you must log in.
130. By Iain Lane

Remove alternate_screen_scroll patch, the symbol in vte does nothing.

131. By Iain Lane

Migrate the transparency settings too

132. By Iain Lane

Update changelog

133. By Iain Lane

Migrate the "Default" profile by default & add more debugging

134. By Iain Lane

Add note

135. By Iain Lane

releasing package gnome-terminal version 3.12.2-0ubuntu1

136. By Tim Lunn

* Add gnome-shell_search_provider.patch: provide a local copy of the dbus
  interface so can build shell search provider without depending on
  gnome-shell which is in universe
* gnome-terminal-data.install: Install search provider

137. By Tim Lunn

add bug ref

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2014-11-05 15:55:32 +0000
+++ debian/changelog 2014-11-07 21:04:57 +0000
@@ -1,3 +1,12 @@
1gnome-terminal (3.12.2-0ubuntu2) UNRELEASED; urgency=medium
2
3 * Add gnome-shell_search_provider.patch: provide a local copy of the dbus
4 interface so can build shell search provider without depending on
5 gnome-shell which is in universe (LP: #1390224)
6 * gnome-terminal-data.install: Install search provider
7
8 -- Tim Lunn <tim@feathertop.org> Sat, 08 Nov 2014 07:53:55 +1100
9
1gnome-terminal (3.12.2-0ubuntu1) vivid; urgency=low10gnome-terminal (3.12.2-0ubuntu1) vivid; urgency=low
211
3 [ Iain Lane ]12 [ Iain Lane ]
413
=== modified file 'debian/gnome-terminal-data.install'
--- debian/gnome-terminal-data.install 2013-05-23 16:41:13 +0000
+++ debian/gnome-terminal-data.install 2014-11-07 21:04:57 +0000
@@ -1,4 +1,4 @@
1usr/share/locale1usr/share/locale
2usr/share/help2usr/share/help
33usr/share/gnome-shell/search-providers
4debian/gnome-terminal.xpm /usr/share/pixmaps4debian/gnome-terminal.xpm /usr/share/pixmaps
55
=== added file 'debian/patches/gnome-shell_search_provider.patch'
--- debian/patches/gnome-shell_search_provider.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/gnome-shell_search_provider.patch 2014-11-07 21:04:57 +0000
@@ -0,0 +1,137 @@
1From 8dc68ba1c6299fc9e334d85930a7b26c4a9a80d6 Mon Sep 17 00:00:00 2001
2From: Tim Lunn <tim@feathertop.org>
3Date: Thu, 16 Oct 2014 09:56:46 +1100
4Subject: [PATCH] Provide a copy of Shell SearchProvider interface file, so we
5 can build shell search provider without build-dep on gnome-shell
6
7---
8 configure.ac | 3 --
9 src/Makefile.am | 2 +-
10 src/org.gnome.ShellSearchProvider2.xml | 87 ++++++++++++++++++++++++++++++++++
11 3 files changed, 88 insertions(+), 4 deletions(-)
12 create mode 100644 src/org.gnome.ShellSearchProvider2.xml
13
14diff --git a/configure.ac b/configure.ac
15index 68e155a..7878988 100644
16--- a/configure.ac
17+++ b/configure.ac
18@@ -184,9 +184,6 @@ AC_ARG_ENABLE([search-provider],
19 AC_MSG_RESULT([$enable_search_provider])
20
21 if test "$enable_search_provider" = "yes"; then
22- AC_CHECK_FILE([$(eval echo $(eval echo $(eval echo ${dbusinterfacedir})))/org.gnome.ShellSearchProvider2.xml],[],
23- [AC_MSG_ERROR([gnome-shell search provider requested but interface definition file not found])])
24-
25 AC_DEFINE([ENABLE_SEARCH_PROVIDER],[1],[Define to enable gnome-shell search provider])
26 fi
27
28diff --git a/src/Makefile.am b/src/Makefile.am
29index 8050f06..4d7bfe6 100644
30--- a/src/Makefile.am
31+++ b/src/Makefile.am
32@@ -327,7 +327,7 @@ gnome_terminal_server_SOURCES += \
33 terminal-search-provider.h \
34 $(NULL)
35
36-terminal-search-provider-gdbus-generated.c terminal-search-provider-gdbus-generated.h: $(dbusinterfacedir)/org.gnome.ShellSearchProvider2.xml Makefile
37+terminal-search-provider-gdbus-generated.c terminal-search-provider-gdbus-generated.h: $(srcdir)/org.gnome.ShellSearchProvider2.xml Makefile
38 $(AM_V_GEN) $(GDBUS_CODEGEN) \
39 --interface-prefix=org.gnome.Shell \
40 --c-namespace=Terminal \
41diff --git a/src/org.gnome.ShellSearchProvider2.xml b/src/org.gnome.ShellSearchProvider2.xml
42new file mode 100644
43index 0000000..9502340
44--- /dev/null
45+++ b/src/org.gnome.ShellSearchProvider2.xml
46@@ -0,0 +1,87 @@
47+<!DOCTYPE node PUBLIC
48+'-//freedesktop//DTD D-BUS Object Introspection 1.0//EN'
49+'http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd'>
50+<node>
51+
52+ <!--
53+ org.gnome.Shell.SearchProvider2:
54+ @short_description: Search provider interface
55+
56+ The interface used for integrating into GNOME Shell's search
57+ interface (version 2).
58+ -->
59+ <interface name="org.gnome.Shell.SearchProvider2">
60+
61+ <!--
62+ GetInitialResultSet:
63+ @terms: Array of search terms, which the provider should treat as logical AND.
64+ @results: An array of result identifier strings representing items which match the given search terms. Identifiers must be unique within the provider's domain, but other than that may be chosen freely by the provider.
65+
66+ Called when the user first begins a search.
67+ -->
68+ <method name="GetInitialResultSet">
69+ <arg type="as" name="terms" direction="in" />
70+ <arg type="as" name="results" direction="out" />
71+ </method>
72+
73+ <!--
74+ GetSubsearchResultSet:
75+ @previous_results: Array of results previously returned by GetInitialResultSet().
76+ @terms: Array of updated search terms, which the provider should treat as logical AND.
77+ @results: An array of result identifier strings representing items which match the given search terms. Identifiers must be unique within the provider's domain, but other than that may be chosen freely by the provider.
78+
79+ Called when a search is performed which is a "subsearch" of
80+ the previous search, e.g. the method may return less results, but
81+ not more or different results.
82+
83+ This allows search providers to only search through the previous
84+ result set, rather than possibly performing a full re-query.
85+ -->
86+ <method name="GetSubsearchResultSet">
87+ <arg type="as" name="previous_results" direction="in" />
88+ <arg type="as" name="terms" direction="in" />
89+ <arg type="as" name="results" direction="out" />
90+ </method>
91+
92+ <!--
93+ GetResultMetas:
94+ @identifiers: An array of result identifiers as returned by GetInitialResultSet() or GetSubsearchResultSet()
95+ @metas: A dictionary describing the given search result, containing a human-readable 'name' (string), along with the result identifier this meta is for, 'id' (string). Optionally, 'icon' (a serialized GIcon as obtained by g_icon_serialize) can be specified if the result can be better served with a thumbnail of the content (such as with images). 'gicon' (a serialized GIcon as obtained by g_icon_to_string) or 'icon-data' (raw image data as (iiibiiay) - width, height, rowstride, has-alpha, bits per sample, channels, data) are deprecated values that can also be used for that purpose. A 'description' field (string) may also be specified if more context would help the user find the desired result.
96+
97+ Return an array of meta data used to display each given result
98+ -->
99+ <method name="GetResultMetas">
100+ <arg type="as" name="identifiers" direction="in" />
101+ <arg type="aa{sv}" name="metas" direction="out" />
102+ </method>
103+
104+ <!--
105+ ActivateResult:
106+ @identifier: A result identifier as returned by GetInitialResultSet() or GetSubsearchResultSet()
107+ @terms: Array of search terms, which the provider should treat as logical AND.
108+ @timestamp: A timestamp of the user interaction that triggered this call
109+
110+ Called when the users chooses a given result. The result should
111+ be displayed in the application associated with the corresponding
112+ provider. The provided search terms can be used to allow launching a full search in
113+ the application.
114+ -->
115+ <method name="ActivateResult">
116+ <arg type="s" name="identifier" direction="in" />
117+ <arg type="as" name="terms" direction="in" />
118+ <arg type="u" name="timestamp" direction="in" />
119+ </method>
120+
121+ <!--
122+ LaunchSearch:
123+ @terms: Array of search terms, which the provider should treat as logical AND.
124+ @timestamp: A timestamp of the user interaction that triggered this call
125+
126+ Asks the search provider to launch a full search in the application for the provided terms.
127+ -->
128+ <method name="LaunchSearch">
129+ <arg type="as" name="terms" direction="in" />
130+ <arg type="u" name="timestamp" direction="in" />
131+ </method>
132+ </interface>
133+</node>
134--
1352.1.0
136
137
0138
=== modified file 'debian/patches/series'
--- debian/patches/series 2014-11-04 12:48:22 +0000
+++ debian/patches/series 2014-11-07 21:04:57 +0000
@@ -6,3 +6,4 @@
660_add_lp_handler.patch660_add_lp_handler.patch
7nautilus-x11.patch7nautilus-x11.patch
861_cwd_fallback.patch861_cwd_fallback.patch
9gnome-shell_search_provider.patch
910
=== modified file 'debian/rules'
--- debian/rules 2014-05-16 11:54:11 +0000
+++ debian/rules 2014-11-07 21:04:57 +0000
@@ -11,7 +11,7 @@
1111
12LDFLAGS += -Wl,-z,defs -Wl,-O1 -Wl,--as-needed12LDFLAGS += -Wl,-z,defs -Wl,-O1 -Wl,--as-needed
1313
14DEB_CONFIGURE_EXTRA_FLAGS += --enable-distro-packaging --disable-search-provider14DEB_CONFIGURE_EXTRA_FLAGS += --enable-distro-packaging --enable-search-provider
1515
16build/gnome-terminal::16build/gnome-terminal::
17 /usr/bin/docbook-to-man debian/gnome-terminal.sgml > debian/gnome-terminal.117 /usr/bin/docbook-to-man debian/gnome-terminal.sgml > debian/gnome-terminal.1

Subscribers

People subscribed via source and target branches

to all changes: