Code review comment for lp:~darkmuggle-deactivatedaccount/ubuntu/oneiric/squid/oneiric

Thanks Clint. I've uploaded a new diff with just runlevel [2345].

~Ben

On 09/19/2011 10:39 AM, Clint Byrum wrote:
> Review: Needs Fixing
>
> Hi Ben, so I think we can actually keep your bug fix and the fix for 561779.
>
> The start on should probably just be
>
> start on runlevel [2345]
>
> And thats *it*
>
> The reason being that in oneiric, runlevel [2345] will not be reached until all static network interfaces are brought up.
>
> I see no reason to try and start it every time a network interface comes up.. its either configured to listen on 0.0.0.0, or its not and the required interfaces are listed in /etc/network/interfaces.
>
> Go ahead and change it to that, and I'll upload. Thanks!
>
>

--

Ben Howard
<email address hidden>
Canonical USA, Inc
GPG ID 0x5406A866