Code review comment for lp:~darkmuggle-deactivatedaccount/cloud-utils/syncimgs

Revision history for this message
Scott Moser (smoser) wrote :

- ubuntu-cloudimg-keyring.gpg.b64
  the file you have here is zero length. also, I've tested that the
  version in trunk when installed does successfully queries (no complaints
  about bad keyring)
- please add debian/control dependensy on python-distro-info, remove dependency on 'distro-info'

- confusing in build_json:
  + xarch = self.arch
  + if 'amd64' in xarch:
  + xarch = 'x86_64'

  is there a reason you used 'in' there? why not ==?

- * The command can use the following as parametes:
  ^ spelling

- for list_cmd, I'm just curious what value today's date could bring:
  - %(date)s: todays date in YYYY-MM-DD format

- for list_cmd, you say it must return '<tag> <build_serial> <arch>

review: Needs Fixing

« Back to merge proposal