1) There is 1 pep8 violation, trunk is pep8 clean, so we should make sure to get this merge cleaned up too.
./quantum/cli.py:322:80: E501 line too long (80 characters)
2) quantum/cli.py should raise an exception when it cant set attachement
except exc.NoResultFound: pass
But, this bug was pre-existing, I'll file something for this.
3) Otherwise, everything looks good! If you can just fix the pep8 change, we can get this bug fix merged in!
« Back to merge proposal
1) There is 1 pep8 violation, trunk is pep8 clean, so we should make sure to get this merge cleaned up too.
./quantum/ cli.py: 322:80: E501 line too long (80 characters)
2) quantum/cli.py should raise an exception when it cant set attachement
except exc.NoResultFound:
pass
But, this bug was pre-existing, I'll file something for this.
3) Otherwise, everything looks good! If you can just fix the pep8 change, we can get this bug fix merged in!