Merge lp:~danrabbit/pantheon-greeter/cosmetic-changes into lp:~elementary-pantheon/pantheon-greeter/trunk

Proposed by Danielle Foré
Status: Merged
Merged at revision: 123
Proposed branch: lp:~danrabbit/pantheon-greeter/cosmetic-changes
Merge into: lp:~elementary-pantheon/pantheon-greeter/trunk
Diff against target: 203 lines (+41/-43)
3 files modified
src/ShadowedLabel.vala (+3/-5)
src/indicators.vala (+12/-12)
src/loginbox.vala (+26/-26)
To merge this branch: bzr merge lp:~danrabbit/pantheon-greeter/cosmetic-changes
Reviewer Review Type Date Requested Status
elementary Pantheon team Pending
Tom Beckmann Pending
Review via email: mp+136110@code.launchpad.net

Description of the change

This branch makes a number of small cosmetic changes:

* adjust shadows on login box
* adjust alignment of widgets in login box
* Slightly smaller text in login box
* render avatars more sharply
* render text shadows slightly below text
* Thinner "wingpanel"
* Style login box closer to popover appearance

To post a comment you must log in.
129. By Danielle Foré

tom is dumb for using tabs

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/ShadowedLabel.vala'
--- src/ShadowedLabel.vala 2012-11-09 23:58:15 +0000
+++ src/ShadowedLabel.vala 2012-11-26 09:41:36 +0000
@@ -45,14 +45,12 @@
45 var layout = Pango.cairo_create_layout (buffer.context);45 var layout = Pango.cairo_create_layout (buffer.context);
46 layout.set_markup (label, -1);46 layout.set_markup (label, -1);
47 47
48 buffer.context.move_to (10, 0);48 buffer.context.move_to (0, 1);
49 buffer.context.set_source_rgba (0, 0, 0, 1);49 buffer.context.set_source_rgba (0, 0, 0, 1);
50 Pango.cairo_show_layout (buffer.context, layout);50 Pango.cairo_show_layout (buffer.context, layout);
51 Pango.cairo_show_layout (buffer.context, layout);
52 buffer.exponential_blur (7);
53 Pango.cairo_show_layout (buffer.context, layout);
54 Pango.cairo_show_layout (buffer.context, layout);
55 buffer.exponential_blur (3);51 buffer.exponential_blur (3);
52
53 buffer.context.move_to (0, 0);
56 buffer.context.set_source_rgba (1, 1, 1, 1);54 buffer.context.set_source_rgba (1, 1, 1, 1);
57 Pango.cairo_show_layout (buffer.context, layout);55 Pango.cairo_show_layout (buffer.context, layout);
58 56
5957
=== modified file 'src/indicators.vala'
--- src/indicators.vala 2012-08-13 16:21:40 +0000
+++ src/indicators.vala 2012-11-26 09:41:36 +0000
@@ -76,17 +76,17 @@
76 76
77 ~Indicators ()77 ~Indicators ()
78 {78 {
79 if (keyboard_pid != 0) {79 if (keyboard_pid != 0) {
80 Posix.kill (keyboard_pid, Posix.SIGKILL);80 Posix.kill (keyboard_pid, Posix.SIGKILL);
81 int status;81 int status;
82 Posix.waitpid (keyboard_pid, out status, 0);82 Posix.waitpid (keyboard_pid, out status, 0);
83 keyboard_pid = 0;83 keyboard_pid = 0;
84 }84 }
85 }85 }
86 86
87 private async void run () {87 private async void run () {
88 try {88 try {
89 var proxy = new GLib.DBusProxy.for_bus_sync (GLib.BusType.SESSION,89 var proxy = new GLib.DBusProxy.for_bus_sync (GLib.BusType.SESSION,
90 GLib.DBusProxyFlags.NONE, null, 90 GLib.DBusProxyFlags.NONE, null,
91 "org.gnome.SettingsDaemon",91 "org.gnome.SettingsDaemon",
92 "/org/gnome/SettingsDaemon",92 "/org/gnome/SettingsDaemon",
@@ -126,7 +126,7 @@
126 (get_widget () as Gtk.Container).add (bar);126 (get_widget () as Gtk.Container).add (bar);
127 127
128 bar.pack_direction = Gtk.PackDirection.RTL;128 bar.pack_direction = Gtk.PackDirection.RTL;
129 height = 28;129 height = 26;
130 130
131 var transp = new Gtk.CssProvider ();131 var transp = new Gtk.CssProvider ();
132 try {132 try {
133133
=== modified file 'src/loginbox.vala'
--- src/loginbox.vala 2012-11-09 19:39:47 +0000
+++ src/loginbox.vala 2012-11-26 09:41:36 +0000
@@ -4,11 +4,11 @@
4 background-image:none;4 background-image:none;
5 background-color:@bg_color;5 background-color:@bg_color;
6 6
7 border-radius: 6px;7 border-radius: 5px;
8 8
9 border-width:1px;9 border-width: 1px;
10 border-style: solid;10 border-style: solid;
11 border-color: alpha (#000, 0.25);11 border-color: alpha (#000, 0.4);
12 }12 }
13""";13""";
1414
@@ -27,10 +27,10 @@
27 Gdk.Pixbuf image;27 Gdk.Pixbuf image;
28 28
29 Granite.Drawing.BufferSurface buffer;29 Granite.Drawing.BufferSurface buffer;
30 int shadow_blur = 20;30 int shadow_blur = 25;
31 int shadow_x = 0;31 int shadow_x = 0;
32 int shadow_y = 4;32 int shadow_y = 6;
33 double shadow_alpha = 0.5;33 double shadow_alpha = 0.6;
34 34
35 LightDM.Greeter greeter;35 LightDM.Greeter greeter;
36 36
@@ -58,7 +58,7 @@
58 this.scale_gravity = Clutter.Gravity.CENTER;58 this.scale_gravity = Clutter.Gravity.CENTER;
59 59
60 try {60 try {
61 this.image = Gtk.IconTheme.get_default ().load_icon ("avatar-default", 96, 0);61 this.image = Gtk.IconTheme.get_default ().load_icon ("avatar-default", 92, 0);
62 } catch (Error e) { warning (e.message); }62 } catch (Error e) { warning (e.message); }
63 63
64 this.avatar = new Gtk.EventBox ();64 this.avatar = new Gtk.EventBox ();
@@ -67,22 +67,23 @@
67 this.login = new Gtk.Button.with_label (_("Login"));67 this.login = new Gtk.Button.with_label (_("Login"));
68 this.settings = new Gtk.ToggleButton ();68 this.settings = new Gtk.ToggleButton ();
69 69
70 avatar.set_size_request (97, 97);70 avatar.set_size_request (92, 92);
71 avatar.valign = Gtk.Align.START;71 avatar.valign = Gtk.Align.START;
72 avatar.visible_window = false;72 avatar.visible_window = false;
73 username.hexpand = true;73 username.hexpand = true;
74 username.halign = Gtk.Align.START;74 username.halign = Gtk.Align.START;
75 username.ellipsize = Pango.EllipsizeMode.END;75 username.ellipsize = Pango.EllipsizeMode.END;
76 username.margin_top = 10;76 username.margin_top = 6;
77 username.height_request = 65;77 username.height_request = 1;
78 login.expand = false;78 login.expand = false;
79 login.height_request = 1;79 login.height_request = 1;
80 login.width_request = 140;80 login.width_request = 120;
81 login.margin_top = 30;81 login.margin_top = 26;
82 login.halign = Gtk.Align.END;82 login.halign = Gtk.Align.END;
83 settings.valign = Gtk.Align.START;83 settings.valign = Gtk.Align.START;
84 settings.relief = Gtk.ReliefStyle.NONE;84 settings.relief = Gtk.ReliefStyle.NONE;
85 settings.add (new Gtk.Image.from_icon_name ("application-menu-symbolic", Gtk.IconSize.MENU));85 settings.add (new Gtk.Image.from_icon_name ("application-menu-symbolic", Gtk.IconSize.MENU));
86 password.margin_top = 11;
86 password.caps_lock_warning = true;87 password.caps_lock_warning = true;
87 password.set_visibility (false);88 password.set_visibility (false);
88 password.key_release_event.connect ( (e) => {89 password.key_release_event.connect ( (e) => {
@@ -94,9 +95,9 @@
94 });95 });
95 96
96 spinner = new Gtk.Spinner ();97 spinner = new Gtk.Spinner ();
97 spinner.valign = Gtk.Align.START;98 spinner.valign = Gtk.Align.CENTER;
98 spinner.start ();99 spinner.start ();
99 spinner.set_size_request (97, 97);100 spinner.set_size_request (92, 24);
100 101
101 grid = new Gtk.Grid ();102 grid = new Gtk.Grid ();
102 103
@@ -108,13 +109,13 @@
108 109
109 grid.margin = shadow_blur + 12;110 grid.margin = shadow_blur + 12;
110 grid.margin_top += 5;111 grid.margin_top += 5;
111 grid.margin_bottom -= 10;112 grid.margin_bottom -= 12;
112 grid.column_spacing = 12;113 grid.column_spacing = 12;
113 114
114 avatar.draw.connect ( (ctx) => {115 avatar.draw.connect ( (ctx) => {
115 Granite.Drawing.Utilities.cairo_rounded_rectangle (ctx, 0.5, 0.5, 116 Granite.Drawing.Utilities.cairo_rounded_rectangle (ctx, 0, 0,
116 avatar.get_allocated_width ()-1, avatar.get_allocated_height ()-1, 5);117 avatar.get_allocated_width (), avatar.get_allocated_height (), 3);
117 Gdk.cairo_set_source_pixbuf (ctx, image, 0.5, 0.5);118 Gdk.cairo_set_source_pixbuf (ctx, image, 0, 0);
118 ctx.fill_preserve ();119 ctx.fill_preserve ();
119 ctx.set_line_width (1);120 ctx.set_line_width (1);
120 ctx.set_source_rgba (0, 0, 0, 0.3);121 ctx.set_source_rgba (0, 0, 0, 0.3);
@@ -180,14 +181,14 @@
180 181
181 this.buffer = new Granite.Drawing.BufferSurface (w, h);182 this.buffer = new Granite.Drawing.BufferSurface (w, h);
182 183
183 this.buffer.context.rectangle (shadow_blur + shadow_x, 184 this.buffer.context.rectangle (shadow_blur + shadow_x + 3,
184 shadow_blur + shadow_y, w - shadow_blur*2 + shadow_x, h - shadow_blur*2 + shadow_y);185 shadow_blur + shadow_y*2, w - shadow_blur*2 + shadow_x - 6, h - shadow_blur*2 - shadow_y);
185 this.buffer.context.set_source_rgba (0, 0, 0, shadow_alpha);186 this.buffer.context.set_source_rgba (0, 0, 0, shadow_alpha);
186 this.buffer.context.fill ();187 this.buffer.context.fill ();
187 this.buffer.exponential_blur (shadow_blur / 2-2);188 this.buffer.exponential_blur (shadow_blur / 2-2);
188 189
189 draw_ref.get_style_context ().render_activity (this.buffer.context, shadow_blur + shadow_x, 190 draw_ref.get_style_context ().render_activity (this.buffer.context, shadow_blur + shadow_x,
190 shadow_blur + shadow_y, w - shadow_blur*2 + shadow_x, h - shadow_blur*2 + shadow_y);191 shadow_blur + shadow_y -2, w - shadow_blur*2 + shadow_x, h - shadow_blur*2);
191 });192 });
192 193
193 this.get_widget ().draw.connect ( (ctx) => {194 this.get_widget ().draw.connect ( (ctx) => {
@@ -208,16 +209,15 @@
208 }209 }
209 210
210 public static string get_user_markup (LightDM.User user, bool title=false) {211 public static string get_user_markup (LightDM.User user, bool title=false) {
211 var color = (title)?"color='#808080'":"";212 return "<span face='Open Sans Light' font='24'>"+user.real_name+"</span>";
212 return "<span face='Open Sans Light' font='32'>"+user.real_name+"</span>";
213 }213 }
214 214
215 public void wrong_pw () {215 public void wrong_pw () {
216 this.password.text = "";216 this.password.text = "";
217 this.animate (Clutter.AnimationMode.EASE_IN_BOUNCE, 200, scale_x:1.3f, scale_y:1.3f).217 this.animate (Clutter.AnimationMode.EASE_IN_BOUNCE, 150, scale_x:0.9f, scale_y: 0.9f).
218 completed.connect ( () => {218 completed.connect ( () => {
219 Clutter.Threads.Timeout.add (1, () => {219 Clutter.Threads.Timeout.add (1, () => {
220 this.animate (Clutter.AnimationMode.EASE_OUT_BOUNCE, 200, scale_x:1.0f, scale_y:1.0f);220 this.animate (Clutter.AnimationMode.EASE_OUT_BOUNCE, 150, scale_x:1.0f, scale_y: 1.0f);
221 return false;221 return false;
222 });222 });
223 });223 });

Subscribers

People subscribed via source and target branches