Merge lp:~danrabbit/appcenter/bitesize-fixes into lp:~elementary-apps/appcenter/appcenter-old

Proposed by Danielle Foré
Status: Merged
Merged at revision: 44
Proposed branch: lp:~danrabbit/appcenter/bitesize-fixes
Merge into: lp:~elementary-apps/appcenter/appcenter-old
Diff against target: 35 lines (+6/-4)
2 files modified
data/appcenter.desktop (+1/-1)
src/Widgets/Pages/AppsInfo.vala (+5/-3)
To merge this branch: bzr merge lp:~danrabbit/appcenter/bitesize-fixes
Reviewer Review Type Date Requested Status
elementary Apps team Pending
Review via email: mp+140561@code.launchpad.net

Description of the change

Fixes 3 bitesize bugs:

* Makes app icons 128px
* Use Granite.utils to apply header classes for app name/description
* Updated the comment in the .desktop file

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/appcenter.desktop'
--- data/appcenter.desktop 2012-12-16 19:35:55 +0000
+++ data/appcenter.desktop 2012-12-18 22:24:19 +0000
@@ -2,7 +2,7 @@
2Type=Application2Type=Application
3Version=0.13Version=0.1
4Name=AppCenter4Name=AppCenter
5Comment=Install your apps in a fancy way5Comment=Find and install apps
6GenericName=application download center6GenericName=application download center
7Exec=appcenter7Exec=appcenter
8Icon=system-software-installer8Icon=system-software-installer
99
=== modified file 'src/Widgets/Pages/AppsInfo.vala'
--- src/Widgets/Pages/AppsInfo.vala 2012-12-18 20:41:02 +0000
+++ src/Widgets/Pages/AppsInfo.vala 2012-12-18 22:24:19 +0000
@@ -114,13 +114,15 @@
114 114
115 set_status ((Info)pkg.info);115 set_status ((Info)pkg.info);
116 116
117 pkg_name.label = "<span size='x-large'><b>%s</b></span>".printf (app.name);117 pkg_name.label = "%s".printf (app.name);
118 short_description.label = "<big>%s</big>".printf (app.summary);118 Granite.Widgets.Utils.apply_text_style_to_label (Granite.TextStyle.H1, pkg_name);
119 short_description.label = "%s".printf (app.summary);
120 Granite.Widgets.Utils.apply_text_style_to_label (Granite.TextStyle.H2, short_description);
119 121
120 description.label = app.description;122 description.label = app.description;
121 123
122 image.set_from_icon_name (app.icon, IconSize.DIALOG);124 image.set_from_icon_name (app.icon, IconSize.DIALOG);
123 image.pixel_size = 96;125 image.pixel_size = 128;
124 126
125 id.label = pkg.get_name();127 id.label = pkg.get_name();
126 version.label = pkg.get_version();128 version.label = pkg.get_version();

Subscribers

People subscribed via source and target branches