AppCenter

Merge lp:~danrabbit/appcenter/bitesize-fixes into lp:~elementary-apps/appcenter/appcenter-old

  1. bitesize-fixes
  2. Merge into appcenter-old
Proposed by Danielle Foré
Status: Merged
Merged at revision: 44
Proposed branch: lp:~danrabbit/appcenter/bitesize-fixes
Merge into: lp:~elementary-apps/appcenter/appcenter-old
Diff against target: 35 lines (+6/-4)
2 files modified
data/appcenter.desktop (+1/-1)
src/Widgets/Pages/AppsInfo.vala (+5/-3)
To merge this branch: bzr merge lp:~danrabbit/appcenter/bitesize-fixes
Reviewer Review Type Date Requested Status
elementary Apps team Pending
Review via email: mp+140561@code.launchpad.net

Description of the change

Fixes 3 bitesize bugs:

* Makes app icons 128px
* Use Granite.utils to apply header classes for app name/description
* Updated the comment in the .desktop file

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/appcenter.desktop'
2--- data/appcenter.desktop 2012-12-16 19:35:55 +0000
3+++ data/appcenter.desktop 2012-12-18 22:24:19 +0000
4@@ -2,7 +2,7 @@
5 Type=Application
6 Version=0.1
7 Name=AppCenter
8-Comment=Install your apps in a fancy way
9+Comment=Find and install apps
10 GenericName=application download center
11 Exec=appcenter
12 Icon=system-software-installer
13
14=== modified file 'src/Widgets/Pages/AppsInfo.vala'
15--- src/Widgets/Pages/AppsInfo.vala 2012-12-18 20:41:02 +0000
16+++ src/Widgets/Pages/AppsInfo.vala 2012-12-18 22:24:19 +0000
17@@ -114,13 +114,15 @@
18
19 set_status ((Info)pkg.info);
20
21- pkg_name.label = "<span size='x-large'><b>%s</b></span>".printf (app.name);
22- short_description.label = "<big>%s</big>".printf (app.summary);
23+ pkg_name.label = "%s".printf (app.name);
24+ Granite.Widgets.Utils.apply_text_style_to_label (Granite.TextStyle.H1, pkg_name);
25+ short_description.label = "%s".printf (app.summary);
26+ Granite.Widgets.Utils.apply_text_style_to_label (Granite.TextStyle.H2, short_description);
27
28 description.label = app.description;
29
30 image.set_from_icon_name (app.icon, IconSize.DIALOG);
31- image.pixel_size = 96;
32+ image.pixel_size = 128;
33
34 id.label = pkg.get_name();
35 version.label = pkg.get_version();

Subscribers

People subscribed via source and target branches