Code review comment for lp:~dannf/ubuntu/saucy/libatasmart/lp1234343

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

This package is already using dh, and instead of including a static patch to update config.{sub,guess} one would ideally automate it, e.g with "dh $@ --with autoreconf" and adding a Build-dep on dh-autoreconf. This is far more minimal patch, which is also suitable to be forwarded to Debian.

I think I will simply upload "--with autoreconf" patch and forward the bug to debian.

review: Needs Fixing

« Back to merge proposal