The current for-loop zeros variable i and only loops once, hence
not all the buffers are free'd. Fix this by setting i correctly.
Detected by CoverityScan, CID#1463415 ("Operands don't affect result")
Fixes: a5073d6054f7 ("RDMA/hns: Add eq support of hip08")
Signed-off-by: Colin Ian King <email address hidden>
Reviewed-by: Yixian Liu <email address hidden>
Signed-off-by: Jason Gunthorpe <email address hidden>
(cherry picked from commit 38759d6175d338fbf9282c8ea2b51f3b7ab9bc98)
Signed-off-by: dann frazier <email address hidden>
Upon detecting both kernel and user space support record doorbell,
the kernel needs to enable this capability in hardware by db_en,
and it should take place before cq context configuration in
hns_roce_cq_alloc. Currently, db_en is configured after cq alloc
and db_map_user has similar problem.
Reported-by: Xiping Zhang <email address hidden>
Fixes: 9b44703d0a21 ("RDMA/hns: Support cq record doorbell for the user space")
Signed-off-by: Yixian Liu <email address hidden>
Signed-off-by: Lijun Ou <email address hidden>
Signed-off-by: Jason Gunthorpe <email address hidden>
(cherry picked from commit e95955773d4357a0b09a43128352047afce8f35b)
Signed-off-by: dann frazier <email address hidden>
The data in resp will be copied from kernel to userspace, thus it needs to
be initialized to zeros to avoid copying uninited stack memory.
Reported-by: Dan Carpenter <email address hidden>
Fixes: e088a685eae9 ("RDMA/hns: Support rq record doorbell for the user space")
Signed-off-by: Yixian Liu <email address hidden>
Signed-off-by: Jason Gunthorpe <email address hidden>
(cherry picked from commit df7e40425813c50cd252e6f5e348a81ef1acae56)
Signed-off-by: dann frazier <email address hidden>
This patch changes the type of cqn from u32 to u64 to keep
userspace and kernel consistent, initializes resp both for
cq and qp to zeros, and also changes the condition judgment
of outlen considering future caps extension.
Suggested-by: Jason Gunthorpe <email address hidden>
Fixes: e088a685eae9 (hns: Support rq record doorbell for the user space)
Fixes: 9b44703d0a21 (hns: Support cq record doorbell for the user space)
Signed-off-by: Yixian Liu <email address hidden>
Signed-off-by: Lijun Ou <email address hidden>
Signed-off-by: Wei Hu (Xavier) <email address hidden>
Signed-off-by: Shaobo Xu <email address hidden>
Signed-off-by: Jason Gunthorpe <email address hidden>
(cherry picked from commit 7b48221cf41a90cf4bfc36e6d699b7fa4169c970)
Signed-off-by: dann frazier <email address hidden>
The hip06 and hip08 run on a little endian ARM, it needs to
revise the annotations to indicate that the HW uses little
endian data in the various DMA buffers, and flow the necessary
swaps throughout.
The imm_data use big endian mode. The cpu_to_le32/le32_to_cpu
swaps are no-op for this, which makes the only substantive
change the handling of imm_data which is now mandatory swapped.
This also keep match with the userspace hns driver and resolve
the warning by sparse.
Signed-off-by: Lijun Ou <email address hidden>
Signed-off-by: Doug Ledford <email address hidden>
(cherry picked from commit 8b9b8d143b467ec9c65f87b7c2596dc2aabe6737)
Signed-off-by: dann frazier <email address hidden>
Add a definition for cpu_show_spectre_v2() to override the generic
version. This has several permuations, though in practice some may not
occur we cater for any combination.
We don't treat the ori31 speculation barrier as a mitigation on its
own, because it has to be *used* by code in order to be a mitigation
and we don't know if userspace is doing that. So if that's all we see
we say:
Vulnerable, ori31 speculation barrier enabled
Signed-off-by: Michael Ellerman <email address hidden>
(cherry picked from commit d6fbe1c55c55c6937cbea3531af7da84ab7473c3 linux-next)
Signed-off-by: Tyler Hicks <email address hidden>
Acked-by: Kamal Mostafa <email address hidden>
Signed-off-by: Seth Forshee <email address hidden>
