Code review comment for ~dannf/canonical-server-hwe-utils:tremont-post-move-test

Revision history for this message
dann frazier (dannf) wrote :

Thanks for the reviews! I provided this MP as a way to share the script - I'm not sure if it makes sense to merge it at all given it's usefulness has run its course. If others think we would use it again, then I'm happy to eliminate the pauli/lassell special cases and rename the script to something more general. Otherwise, I think we could just reject.

On fping vs. ping, I reach for fping in cases like this out of habit. ISTR only fping used to support exiting non-zero on failure, but that's a 10+ year old habit, and I don't see a reason we need to use fping. I'd be happy to change that too if we decide to keep this.

As for the readable output, yeah - I agree it's not ideal, it was just the easiest thing to put together in the 20 minutes I had. I don't see having time to prioritize improving it though - so (again, if we want to merge this at all) I think we'd have to keep it as-is, or hand off to someone else if addressing that is required.

Perhaps let us discuss in the scalebot call.

« Back to merge proposal