Code review comment for ~dannf/canonical-server-hwe-utils:tremont-post-move-test
Revision history for this message
| Hon Ming Hui (hm-hui) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
7020100
(Get the code!)
Further comment after trying that once.
I realise that it is using fping instead of ping, which is fine I could easily install it.
The main problem for me is that the python unittest result print a complete stack trace which make it difficult (or just very long result) to demonstrate the failure machine.
On the other hand, one feature that fping has while ping do not have is that it could accept a list of IP in single command so that it will print the summary as a result.
e.g.
10.228.68.47 : xmt/rcv/%loss = 1/0/100%
10.228.0.22 : xmt/rcv/%loss = 1/0/100%
10.228.68.18 : xmt/rcv/%loss = 1/0/100%
10.228.68.44 : xmt/rcv/%loss = 1/1/0%, min/avg/max = 83.6/83.6/83.6
But fping is not able to show the machine name in machine.yaml which is also not ideal.
I don't have a concrete idea on how to improve it but I think if the script result could be neat and just show the list of success/failure machines. That will be better.