Code review comment for ~dannf/+git/maas-preseeds:workaround-lp2037682
Revision history for this message
| Mitchell Augustin (mitchellaugustin) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
7020100
(Get the code!)
I don't think this will solve the issue on its own without my proposed changes to Curtin (WIP as of typing this) or DKMS also getting pulled in. While this would resolve any issues at this stage currently caused by spurious ischroot exit codes, we don't actually reach any of those in the DKMS issue since the isolated /proc is not mounted, meaning we get the hang because of the wrong PID being checked. Right now, if it makes it past that, ischroot still returns true as expected because our /procs don't match up.
Once our Curtin changes get pulled in that add --mount-proc, this would work, but it will be redundant since I am also including the same change for all in-target commands.