Merge lp:~danilovesky/workcraft/trunk-bug-1350787 into lp:workcraft

Proposed by Danil Sokolov
Status: Merged
Merged at revision: 596
Proposed branch: lp:~danilovesky/workcraft/trunk-bug-1350787
Merge into: lp:workcraft
Diff against target: 267 lines (+79/-56)
5 files modified
WorkcraftCore/src/org/workcraft/Info.java (+1/-1)
WorkcraftCore/src/org/workcraft/gui/MainWindow.java (+76/-47)
build_distr.sh (+0/-6)
build_distr_linux.sh (+1/-1)
build_distr_windows.sh (+1/-1)
To merge this branch: bzr merge lp:~danilovesky/workcraft/trunk-bug-1350787
Reviewer Review Type Date Requested Status
Danil Sokolov Approve
Review via email: mp+253206@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Danil Sokolov (danilovesky) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'WorkcraftCore/src/org/workcraft/Info.java'
2--- WorkcraftCore/src/org/workcraft/Info.java 2015-02-28 23:14:51 +0000
3+++ WorkcraftCore/src/org/workcraft/Info.java 2015-03-17 14:02:13 +0000
4@@ -13,7 +13,7 @@
5 private static final int majorVersion = 3;
6 private static final int minorVersion = 0;
7 private static final int revisionVersion = 4;
8- private static final String statusVersion = "alpha"; // alpha, beta, rc1, rc2
9+ private static final String statusVersion = null; // "alpha", "beta", "rc1", null (for release)
10
11 private static final int startYear = 2006;
12 private static final int currentYear = Calendar.getInstance().get(Calendar.YEAR);
13
14=== modified file 'WorkcraftCore/src/org/workcraft/gui/MainWindow.java'
15--- WorkcraftCore/src/org/workcraft/gui/MainWindow.java 2015-02-10 15:21:12 +0000
16+++ WorkcraftCore/src/org/workcraft/gui/MainWindow.java 2015-03-17 14:02:13 +0000
17@@ -23,8 +23,12 @@
18
19 import java.awt.BorderLayout;
20 import java.awt.Color;
21+import java.awt.DisplayMode;
22 import java.awt.Font;
23+import java.awt.Insets;
24 import java.awt.Point;
25+import java.awt.Rectangle;
26+import java.awt.Toolkit;
27 import java.awt.event.WindowAdapter;
28 import java.awt.event.WindowEvent;
29 import java.awt.font.FontRenderContext;
30@@ -346,6 +350,21 @@
31 utilityWindows.add(dockableWindow);
32 }
33
34+ public void setWindowSize(boolean maximised, int width, int height){
35+ if(maximised){
36+ DisplayMode mode = this.getGraphicsConfiguration().getDevice().getDisplayMode();
37+ Insets insets = Toolkit.getDefaultToolkit().getScreenInsets(this.getGraphicsConfiguration());
38+ this.setMaximizedBounds(new Rectangle(
39+ mode.getWidth() - insets.right - insets.left,
40+ mode.getHeight() - insets.top - insets.bottom
41+ ));
42+ this.setExtendedState(this.getExtendedState() | JFrame.MAXIMIZED_BOTH);
43+ this.setSize(mode.getWidth() - insets.right - insets.left, mode.getHeight() - insets.top - insets.bottom);
44+ }else{
45+ this.setExtendedState(JFrame.NORMAL);
46+ }
47+ }
48+
49 public void startup() {
50 MainWindowIconManager.apply(this);
51
52@@ -375,13 +394,6 @@
53 rootDockingPort = new DefaultDockingPort("defaultDockingPort");
54 content.add(rootDockingPort, BorderLayout.CENTER);
55
56- boolean maximised = Boolean.parseBoolean(framework
57- .getConfigVar("gui.main.maximised"));
58- String w = framework.getConfigVar("gui.main.width");
59- String h = framework.getConfigVar("gui.main.height");
60- int width = (w == null) ? 800 : Integer.parseInt(w);
61- int height = (h == null) ? 600 : Integer.parseInt(h);
62-
63 lastSavePath = framework.getConfigVar("gui.main.lastSavePath");
64 lastOpenPath = framework.getConfigVar("gui.main.lastOpenPath");
65 for (int i = 0; i < CommonEditorSettings.getRecentCount(); i++) {
66@@ -390,12 +402,23 @@
67 }
68 mainMenu.setRecentMenu(new ArrayList<String>(recentFiles));
69
70+ String maximisedStr = framework.getConfigVar("gui.main.maximised");
71+ String widthStr = framework.getConfigVar("gui.main.width");
72+ String heightStr = framework.getConfigVar("gui.main.height");
73+
74+ boolean maximised = (maximisedStr == null) ? true : Boolean.parseBoolean(maximisedStr);
75+ this.setExtendedState(maximised ? JFrame.MAXIMIZED_BOTH : JFrame.NORMAL);
76+
77+ DisplayMode mode = this.getGraphicsConfiguration().getDevice().getDisplayMode();
78+ Insets insets = Toolkit.getDefaultToolkit().getScreenInsets(this.getGraphicsConfiguration());
79+ int width = mode.getWidth() - insets.right - insets.left;
80+ int height = mode.getHeight() - insets.top - insets.bottom;
81+ if ((widthStr != null) && (heightStr != null)) {
82+ width = Integer.parseInt(widthStr);
83+ height = Integer.parseInt(heightStr);
84+ }
85 this.setSize(width, height);
86
87- if (maximised) {
88- setExtendedState(MAXIMIZED_BOTH);
89- }
90-
91 createWindows();
92
93 outputWindow.captureStream();
94@@ -404,44 +427,50 @@
95 rootDockingPort.setBorderManager(new StandardBorderManager(
96 new ShadowBorder()));
97
98- outputDockable = createDockableWindow(outputWindow, "Output",
99- DockableWindowContentPanel.CLOSE_BUTTON,
100- DockingManager.SOUTH_REGION, 0.8f);
101-
102- DockableWindow problems = createDockableWindow(errorWindow, "Problems",
103- outputDockable, DockableWindowContentPanel.CLOSE_BUTTON);
104-
105-
106- DockableWindow javaScript = createDockableWindow(jsWindow,
107- "Javascript", outputDockable,
108- DockableWindowContentPanel.CLOSE_BUTTON);
109-
110- DockableWindow wsvd = createDockableWindow(workspaceWindow,
111- "Workspace", DockableWindowContentPanel.CLOSE_BUTTON,
112- DockingManager.EAST_REGION, 0.8f);
113+ float xSplit = 0.88f;
114+ float ySplit = 0.82f;
115+ outputDockable = createDockableWindow(
116+ outputWindow, "Output",
117+ DockableWindowContentPanel.CLOSE_BUTTON,
118+ DockingManager.SOUTH_REGION, ySplit);
119+
120+ DockableWindow problems = createDockableWindow(
121+ errorWindow, "Problems", outputDockable,
122+ DockableWindowContentPanel.CLOSE_BUTTON);
123+
124+ DockableWindow javaScript = createDockableWindow(
125+ jsWindow, "Javascript", outputDockable,
126+ DockableWindowContentPanel.CLOSE_BUTTON);
127+
128+ DockableWindow wsvd = createDockableWindow(
129+ workspaceWindow, "Workspace",
130+ DockableWindowContentPanel.CLOSE_BUTTON,
131+ DockingManager.EAST_REGION, xSplit);
132+
133 DockableWindow propertyEditor = createDockableWindow(
134 propertyEditorWindow, "Property editor", wsvd,
135 DockableWindowContentPanel.CLOSE_BUTTON,
136- DockingManager.NORTH_REGION, 0.5f);
137- DockableWindow toolbox = createDockableWindow(toolboxWindow,
138- "Editor tools", propertyEditor,
139- DockableWindowContentPanel.HEADER
140- | DockableWindowContentPanel.CLOSE_BUTTON,
141- DockingManager.SOUTH_REGION, 0.5f);
142- DockableWindow tiw = createDockableWindow(toolInterfaceWindow,
143- "Tool controls", toolbox,
144+ DockingManager.NORTH_REGION, ySplit);
145+
146+ DockableWindow tiw = createDockableWindow(
147+ toolInterfaceWindow, "Tool controls", propertyEditor,
148 DockableWindowContentPanel.CLOSE_BUTTON,
149- DockingManager.SOUTH_REGION, 0.5f);
150-
151- documentPlaceholder = createDockableWindow(new DocumentPlaceholder(),
152- "", null, outputDockable, 0, DockingManager.NORTH_REGION, 0.8f,
153- "DocumentPlaceholder");
154+ DockingManager.SOUTH_REGION, 0.4f);
155+
156+ DockableWindow toolbox = createDockableWindow(
157+ toolboxWindow, "Editor tools", tiw,
158+ DockableWindowContentPanel.HEADER | DockableWindowContentPanel.CLOSE_BUTTON,
159+ DockingManager.SOUTH_REGION, 0.82f);
160+
161+ documentPlaceholder = createDockableWindow(
162+ new DocumentPlaceholder(), "", null, outputDockable,
163+ 0, DockingManager.NORTH_REGION, ySplit, "DocumentPlaceholder");
164
165 DockingManager.display(outputDockable);
166- EffectsManager.setPreview(new AlphaPreview(Color.BLACK, Color.GRAY,
167- 0.5f));
168+ EffectsManager.setPreview(new AlphaPreview(Color.BLACK, Color.GRAY, 0.5f));
169
170- DockableWindow tasks = createDockableWindow(new TaskManagerWindow(), "Tasks", outputDockable,
171+ DockableWindow tasks = createDockableWindow(
172+ new TaskManagerWindow(), "Tasks", outputDockable,
173 DockableWindowContentPanel.CLOSE_BUTTON);
174
175 setVisible(true);
176@@ -718,8 +747,9 @@
177 saveDockingLayout();
178
179 content.remove(rootDockingPort);
180-
181- framework.setConfigVar("gui.main.maximised", Boolean.toString((getExtendedState() & JFrame.MAXIMIZED_BOTH) != 0));
182+
183+ boolean maximised = ((getExtendedState() & JFrame.MAXIMIZED_BOTH) != 0);
184+ framework.setConfigVar("gui.main.maximised", Boolean.toString(maximised));
185 framework.setConfigVar("gui.main.width", Integer.toString(getWidth()));
186 framework.setConfigVar("gui.main.height", Integer.toString(getHeight()));
187
188@@ -928,7 +958,6 @@
189 }
190 openWork(f);
191 }
192- lastOpenPath = fc.getCurrentDirectory().getPath();
193 } else {
194 throw new OperationCancelledException("Open operation cancelled by user.");
195 }
196@@ -943,6 +972,7 @@
197 createEditorWindow(we);
198 }
199 pushRecentFile(f.getPath(), true);
200+ lastOpenPath = f.getParent();
201 } catch (DeserialisationException e) {
202 JOptionPane.showMessageDialog(this,
203 "A problem was encountered while trying to load \"" + f.getPath() + "\".\n"
204@@ -964,7 +994,6 @@
205 }
206 mergeWork(f);
207 }
208- lastOpenPath = fc.getCurrentDirectory().getPath();
209 } else {
210 throw new OperationCancelledException("Merge operation cancelled by user.");
211 }
212@@ -1098,7 +1127,6 @@
213 for (File f : fc.getSelectedFiles()) {
214 importFrom(f, importers);
215 }
216- lastOpenPath = fc.getCurrentDirectory().getPath();
217 }
218 }
219
220@@ -1111,6 +1139,7 @@
221 ModelEntry me = Import.importFromFile(importer, f);
222 me.getModel().setTitle(FileUtils.getFileNameWithoutExtension(f));
223 framework.getWorkspace().add(Path.<String> empty(), f.getName(), me, false, me.isVisual());
224+ lastOpenPath = f.getParent();
225 break;
226 } catch (IOException e) {
227 e.printStackTrace();
228
229=== modified file 'build_distr.sh'
230--- build_distr.sh 2015-01-26 22:10:33 +0000
231+++ build_distr.sh 2015-03-17 14:02:13 +0000
232@@ -92,9 +92,3 @@
233 do
234 cp -r $src_dir/$i $distr_dir/
235 done
236-
237-# Copy config
238-if [ -e $src_dir/config ]
239-then
240- cp -r $src_dir/config $distr_dir/
241-fi
242
243=== modified file 'build_distr_linux.sh'
244--- build_distr_linux.sh 2015-02-28 23:14:51 +0000
245+++ build_distr_linux.sh 2015-03-17 14:02:13 +0000
246@@ -1,7 +1,7 @@
247 #!/usr/bin/env bash
248
249 src_dir="."
250-distr_dir="../../workcraft_3.0.4_alpha"
251+distr_dir="../../workcraft_3.0.4"
252 template_dir="../../distr-template-linux"
253
254 ./build_distr.sh -s $src_dir -d $distr_dir -t $template_dir
255
256=== modified file 'build_distr_windows.sh'
257--- build_distr_windows.sh 2015-02-28 23:14:51 +0000
258+++ build_distr_windows.sh 2015-03-17 14:02:13 +0000
259@@ -1,7 +1,7 @@
260 #!/usr/bin/env bash
261
262 src_dir="."
263-distr_dir="../../workcraft_3.0.4_alpha"
264+distr_dir="../../workcraft_3.0.4"
265 template_dir="../../distr-template-windows"
266
267 ./build_distr.sh -s $src_dir -d $distr_dir -t $template_dir

Subscribers

People subscribed via source and target branches