#0 was just a recommendation that would have helped me, nothing to fix here
#1 is done - thanks
#2 is done - thanks
#3 is done
I know often we finds bad examples in other places :-)
But if - like in this case - doing it better isn't too complex we should try to do so.
Thanks for adding what I wanted :-) !
#4 was only about style anyway (not a blocker) and you have adapted them a bit - thanks.
Overall, all open issues are addressed.
I do not see anything further that is of deep concern.
+1 now
Doing some final checks and then likely uploading ...
P.S. Not a blocker, but a hint. That test timing fix you did is IMHO generally helpful.
And before forgetting about this package you might want to submit it to Debian?
Having a look again
#0 was just a recommendation that would have helped me, nothing to fix here
#1 is done - thanks
#2 is done - thanks
#3 is done
I know often we finds bad examples in other places :-)
But if - like in this case - doing it better isn't too complex we should try to do so.
Thanks for adding what I wanted :-) !
#4 was only about style anyway (not a blocker) and you have adapted them a bit - thanks.
Overall, all open issues are addressed.
I do not see anything further that is of deep concern.
+1 now
Doing some final checks and then likely uploading ...
P.S. Not a blocker, but a hint. That test timing fix you did is IMHO generally helpful.
And before forgetting about this package you might want to submit it to Debian?