Code review comment for ~danilogondolfo/ubuntu/+source/firebird3.0:mantic_merge_1

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Hi,
the Ubuntu delta on this is small and retained correctly.
But I'm not entirely sure it is worth it and I feel uncomfortable carrying this forward without asking some questions.

I mean, march helps, but how much?
Is it worth the effort for this to not be a sync?
Could I ask you to talk to Gianfranco (the author) about the background when it was added (there is no LP bug) and how much the gain was.

If that is not known, you might do an investigation on your own, file that and
a) proven improvement - refer to the bug in the changelog
b) no improvement - we make this a sync again

Even in case of (a) you might want to prep something that does this change via dpkg-vendor in d/rules so that it can be a sync after accepted in Debian.

P.S. does it even have effect, it is well hidden so it can not be seen int he buildlog?!

review: Needs Information

« Back to merge proposal