Code review comment for ~danilogondolfo/ubuntu/+source/diffoscope:merge_mantic_1

Revision history for this message
Danilo Egea Gondolfo (danilogondolfo) wrote :

Thank you, Christian.

I'm not sure what happened, but the build is failing because some binary files used by some tests are missing.

See https://git.launchpad.net/ubuntu/+source/diffoscope/commit/?id=5cdc4d6a9ceea850be325ddf933b6bd5226108cf

The diff between ubuntu/devel and debian/sid now contains this:

diff --git a/tests/data/elfmix2.a b/tests/data/elfmix2.a
deleted file mode 100644
index c0269b7..0000000
Binary files a/tests/data/elfmix2.a and /dev/null differ
diff --git a/tests/data/test1.a b/tests/data/test1.a
deleted file mode 100644
index 501ca17..0000000
Binary files a/tests/data/test1.a and /dev/null differ
diff --git a/tests/data/test1.o b/tests/data/test1.o
deleted file mode 100644
index a94647d..0000000
Binary files a/tests/data/test1.o and /dev/null differ
diff --git a/tests/data/test2.a b/tests/data/test2.a
deleted file mode 100644
index 4d6f65a..0000000
Binary files a/tests/data/test2.a and /dev/null differ
diff --git a/tests/data/test2.o b/tests/data/test2.o
deleted file mode 100644
index 1e0bb82..0000000
Binary files a/tests/data/test2.o and /dev/null differ

They are not present in the tarball you uploaded. Those deletions are not part of my MP.

« Back to merge proposal