Code review comment for ~danilogondolfo/ubuntu/+source/diffoscope:merge_mantic_1

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

While this misses the old delta as well, it is trivial enough (not like sudo) to have a look.

You link to LP: #2026151 which tracks the test failures in Ubuntu Infra - thanks!
Thanks for also retrying "The patch is still present because it's still failing on armhf."

* Changelog:
  - [+] changelog entry correct version and targeted codename
  - [+] changelog entries correct
  - [+] bug references correct
  - [+] update-maintainer has been run

* Merge - Indirect Changes:
  - [+] no upstream (=debian in this case) changes that need adaptation
  - [+] no further upstream version to consider
  - [+] debian changes look safe

* Merge - Old Delta:
  - [n/a] dropped changes are ok to be dropped
  - [+] nothing else to drop

* New Delta:
  - [+] no new patches added

* Git/Maintenance
  - [n/a] testcases added or not needed for this
  - [+] commits are properly split (more important on -dev than on SRUs)

* Build/Test (on the PPA I found from your bug):
  - [+] build is ok
  - [+] verified PPA package installs/uninstalls
  - [+] autopkgtest is fine (based on you testing the fix, I haven't seen it)
  - [+] sanity checks test fine

review: Approve

« Back to merge proposal