Code review comment for lp:~danilo/maas/virsh-storage-units-trunk

Revision history for this message
Данило Шеган (danilo) wrote :

I've addressed your review comments: moved the function into provisioningserver.utils.convert_size_to_bytes and added unit tests (thanks for raising this, I was going to add them then I got side-tracked filing other bugs as offshoots of the original one, and it slipped!).

« Back to merge proposal