Code review comment for lp:~danilo/launchpad/bugtask-index-portlet-setup

Revision history for this message
Graham Binns (gmb) wrote :

1184 +var use_advanced_subscriptions = false;

ha, so here's an interesting thing. that should be
`var namespace.use_advanced_subscriptions = false;`. i guess that it's
never been a problem because our code doesn't check for
namespace.use_advanced_subscriptions being undefined. you can get rid of
the xxx above this too since rob and i agreed it wasn't a bug after all.

you're also going to need to update the setting of
y.lp.bugs.bugtask_index.use_advanced_subscriptions in bugtask-index.pt
to make sure it uses the new namespace, otherwise all of the advanced
subscriptions functionality is going to break.

You can double-check the new functionality by running the following query and then checking that the "Subscribe / Edit subscription" link behaves like it does for you on production:

`insert into featureflag (scope, priority, flag, value, date_modified) values ('default', 1, 'malone.advanced-subscriptions.enabled', 'on', now() at time zone 'UTC');`

review: Approve (code)

« Back to merge proposal