Merge lp:~danilo/launchpad/bug-999040 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | William Grant | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 15248 | ||||
Proposed branch: | lp:~danilo/launchpad/bug-999040 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
44 lines (+15/-1) 2 files modified
lib/lp/registry/model/person.py (+3/-1) lib/lp/registry/tests/test_person.py (+12/-0) |
||||
To merge this branch: | bzr merge lp:~danilo/launchpad/bug-999040 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+105637@code.launchpad.net |
Commit message
Do not show removed work items on person/team's upcoming work pages.
Description of the change
= Bug 999040: deleted work items show up in upcoming work views =
== Proposed fix ==
Do not include deleted work items in returned values from
IPerson.
== Pre-implementation notes ==
None.
== LOC Rationale ==
This is a 1-line bug fix with the test.
Prior to work being started on workitems, several thousands of lines of code have been removed by Salgado.
== Implementation details ==
Add 'WorkItem.deleted == False' to the SQL query.
A single lint fix as well.
== Tests ==
bin/test -cvvt test_skips_
== Demo and Q/A ==
Eg. on qastaging:
1. Create a BP and assign it to yourself (this means all workitems will be assigned to you by default)
2. Target that BP to a milestone with the target date set and in the future (or it won't be "upcoming work")
3. Create two workitems in it, save.
4. Remove one workitem.
5. Go to https:/
Only the non-deleted work item should show up.
Note that feature flag needs to be set as well (though, it's already set for us).
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
This probably needs a followup to offset the LOC addition, but otherwise looks reasonable.