Code review comment for lp:~danilo/launchpad/bug-662552-fast-pofile-selection

Revision history for this message
Gavin Panella (allenap) wrote :

Looks good, especially if it's 100 times faster!

If you want to use Storm syntax, it may work just as well to use an IN
query:

   SELECT POFile.*
     FROM POFile
    WHERE POFile.potemplate IN (
            SELECT potemplate
              FROM TranslationTemplateItem
             WHERE potmsgset = 1
               AND sequence > 0)
    LIMIT 1;

If PostgreSQL is sensible it will optimize that. But, to be honest, if
what you've got works, use it and ignore me :)

review: Approve

« Back to merge proposal