Code review comment for lp:~danilo/launchpad/bug-516317

Revision history for this message
Henning Eggers (henninge) wrote :

Hi Danilo,
thank you for doing this and also for pointing out the caveats - makes life easy for me. ;)

I think there should be only one "Configure translations" link and it should be near the top. I guess the intention of that placement near the help link is to make it easy for project maintainers to start on translations. That is not so important on distributions as they don't get started very often. Also, the current placement at the bottom is in the "permissions" portlet but this page is not just about permissions any more, even before this branch. So, a general placement in the top portlet seems logical.

Another little thing: The check box on the distribution configuration page is labelled "Translations for this project are done in Launchpad" - can you put "distribution" there, please?

Cheers,
Henning

review: Needs Fixing (ui)

« Back to merge proposal