Code review comment for lp:~danilo/landscape-charm/maintenance-hook

On Tue, Jun 02, 2015 at 07:02:10AM -0000, Данило Шеган wrote:
> @Free, Bjorn: I'll move to action_fail (it's already there in core.hookenv.action_fail).

Thanks.

> As for not using maintenance file, the entire goal of this branch is
> to move all dependencies on maint-file into a single place, which we can
> easily change (I was thinking of future move to juju unit status, tbh: I
> would only implement internal representation of status if we really need
> it, and I am not sure yet if we do, for eg. waiting for batch scripts to
> finish).

I think using the maintenance file is fine. Using it ensures that we
don't do anything bad if some other admin decided to start the servers
and removing the maintenance file. We should detect that situation
rather than ignore it.

When we have Juju unit status, we should check that as well, but I don't
see a reason not to check the maintenance file.