Code review comment for lp:~danilo/charms/trusty/haproxy/merge-services-fix

Revision history for this message
Björn Tillenius (bjornt) wrote :

> Gave each branch a lookover and tested merging them and running tests
>
> - tests are missing an install for flake8
> - lint returns following errors:
> F401 'groupby' imported but unused
> E111 indentation is not a multiple of four
>
> Deployment tests pass. Merge the Bjorn's branch and fix up the flake8 install
> and minor lint errors and should be good to go.

Thanks for the review Whit. I fixed the lint added python-flake8 to be installed
in my branch, since Danilo is away.

« Back to merge proposal