Code review comment for lp:~danilo/charms/trusty/glance-simplestreams-sync/lathiats-endpoints-fix

Revision history for this message
Adam Collard (adam-collard) wrote :

Not in this diff but the warning log about finding the wrong number of endpoints is bogus.

    if len(ps_endpoints) != 1:
        log.warning("found {} product-streams endpoints in region {},"
                    " expecting one - not updating"
                    " endpoint".format(ps_endpoints, region,
                                       len(ps_endpoints)))

It has two placeholders and three values to format in there.

It's crying out for tests.

review: Needs Fixing

« Back to merge proposal