Code review comment for lp:~danigm/bzr-email/branch-commit-to

Revision history for this message
Robert Collins (lifeless) wrote :

Hi, thanks for this merge proposal.

I don't understand why all this is needed, and you proposal doesn't
explain either. There are a number of structural issues, such as using
GlobalConfig directly, and using private variables, which I can't assess
until I know the reason for the changes.

Could you please explain in more detail what was wrong that you needed
to change to make things work.

Thanks,
Rob

 review: needsinfo

review: Needs Information

« Back to merge proposal