Code review comment for lp:~danielholm/music-app/search

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Ok its looking good :)

I agree that ideally the TextField should auto focus.
I think that the results should clear when the search box is empty.

Also I think the delay of 2 seconds maybe to high (at least for desktop, maybe it is ok for mobile with the touch keyboard?), what do you guys think?

Another feature we could add is a count of how many tracks were returned.

Other than these minor points, which can either be done in this branch or another, I approve.

review: Approve

« Back to merge proposal