Code review comment for lp:~daniel-wyatt/midori/fix-bug820735

Revision history for this message
Cris Dywan (kalikiana) wrote :

The code in midori_view_web_view_resource_response_cb uses midori_browser_get_current_uri in the View to see if a particular resource happens to be loading the top level website of the active tab… if you wanted to check every top-level URL typed in the address bar _action_location_submit_uri in midori-browser.c would be the place.

The other code doesn't and can't check where the error came from and thus skips all errors regardless of the resource check so… what's the specific intention of the code? Should it be specific to typos or include all errors? Both do not mix.

review: Needs Information

« Back to merge proposal