Merge lp:~daniel-watkins-credativ/poweremail/fix-server-actions into lp:~openerp-commiter/poweremail/poweremail-v6

Proposed by Daniel Watkins (credativ)
Status: Merged
Merged at revision: 215
Proposed branch: lp:~daniel-watkins-credativ/poweremail/fix-server-actions
Merge into: lp:~openerp-commiter/poweremail/poweremail-v6
Diff against target: 23 lines (+14/-0)
1 file modified
poweremail_serveraction_view.xml (+14/-0)
To merge this branch: bzr merge lp:~daniel-watkins-credativ/poweremail/fix-server-actions
Reviewer Review Type Date Requested Status
Niels Huylebroeck (community) Approve
Review via email: mp+34435@code.launchpad.net

Description of the change

Currently Poweremail Server Actions cannot be saved, as there is a required field that has not been overriden. This overrides that field.

To post a comment you must log in.
206. By Daniel Watkins (credativ)

Fix my fix of new required attribute.

Revision history for this message
Niels Huylebroeck (red15) wrote :

Just goes to show that openerp can sometimes really think backwards, why didn't they just say

attrs="{'required': [('state','=','copy_object')]}"

But I tested it and this fix works too :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'poweremail_serveraction_view.xml'
2--- poweremail_serveraction_view.xml 2009-08-04 10:33:25 +0000
3+++ poweremail_serveraction_view.xml 2010-09-07 10:29:43 +0000
4@@ -42,6 +42,20 @@
5 </xpath>
6 </field>
7 </record>
8+ <record model="ir.ui.view"
9+ id="view_server_action_form_poweremail_3">
10+ <field name="name">ir.actions.server.form.poweremail_1</field>
11+ <field name="model">ir.actions.server</field>
12+ <field name="type">form</field>
13+ <field name="inherit_id" ref="base.view_server_action_form" />
14+ <field name="arch" type="xml">
15+ <xpath
16+ expr="/form/notebook/page/field[@name='copy_object']"
17+ position="replace">
18+ <field name="copy_object" on_change="change_object(copy_object, state)" select="2" attrs="{'required':[('state','!=','dummy'), ('state','!=','sms'), ('state','!=','code'), ('state','!=','loop'), ('state','!=','trigger'), ('state','!=','object_write'), ('state','!=','object_create'), ('state','!=','client_action'), ('state','!=','email'), ('state','!=','sms'), ('state','!=','other'), ('state','!=','poweremail')]}"/>
19+ </xpath>
20+ </field>
21+ </record>
22 </data>
23 </openerp>
24

Subscribers

People subscribed via source and target branches