Merge lp:~daniel-watkins-credativ/openobject-addons/crm_max_fix into lp:openobject-addons

Proposed by Daniel Watkins (credativ)
Status: Merged
Merge reported by: Rucha (Open ERP)
Merged at revision: not available
Proposed branch: lp:~daniel-watkins-credativ/openobject-addons/crm_max_fix
Merge into: lp:openobject-addons
Diff against target: 12 lines (+1/-1)
1 file modified
crm/crm_action_rule.py (+1/-1)
To merge this branch: bzr merge lp:~daniel-watkins-credativ/openobject-addons/crm_max_fix
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+34526@code.launchpad.net

Description of the change

Currently, the "Maximum Communication History" field in the Conditions tab of the Automated Actions form actually defines a minimum. This one-line patch changes it back to what the label suggests should be happening.

To post a comment you must log in.
Revision history for this message
Rucha (Open ERP) (rpa-openerp) wrote :

Thanks Daniel for the solution

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'crm/crm_action_rule.py'
--- crm/crm_action_rule.py 2010-07-09 12:14:44 +0000
+++ crm/crm_action_rule.py 2010-09-03 11:19:59 +0000
@@ -96,7 +96,7 @@
96 res_count = True96 res_count = True
97 if action.trg_max_history:97 if action.trg_max_history:
98 res_count = False98 res_count = False
99 if len(obj.message_ids) >= action.trg_max_history:99 if len(obj.message_ids) <= action.trg_max_history:
100 res_count = True100 res_count = True
101 ok = ok and res_count101 ok = ok and res_count
102 return ok102 return ok

Subscribers

People subscribed via source and target branches

to all changes: