Code review comment for ~daniel-kaluza-dk/dpcs:settingsPanel

Revision history for this message
Mateusz Susik (mateuszsusik) wrote :

1). The settings file is uncleae - I see only ones and zeros after opening it with a text editor and I don't know whoch value corresponds to which option. If you don't want to spend time on parsing, use JSON format.

2). panelEvoker should have if __name__ == "__main__"

3). panelEvoker introduces additional requirement: superuser must have access to Python. On some computers Python is not available and it should be possible to change settings without global python installation. You should be able to implement a solution where you ask the user for a password and then use it for handling the file.

« Back to merge proposal