Code review comment for lp:~dandrader/unity8/tutorial-launcher-gap

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

On 09/07/15 09:39, Albert Astals Cid wrote:
> FWIW
>
> === modified file 'tests/qmltests/Tutorial/tst_Tutorial.qml'
> --- tests/qmltests/Tutorial/tst_Tutorial.qml 2015-07-02 16:13:08 +0000
> +++ tests/qmltests/Tutorial/tst_Tutorial.qml 2015-07-09 11:33:14 +0000
> @@ -332,14 +332,14 @@
> verify(teaseAnimation.running);
>
> // Start a drag, make sure animation stops
> - touchFlick(shell, 0, halfHeight, units.gu(3), halfHeight, true, false);
> + touchFlick(shell, 0, halfHeight, units.gu(4), halfHeight, true, false);
> verify(!teaseAnimation.running);
> verify(launcher.visibleWidth > 0);
> verify(launcher.x > 0);
> compare(launcher.x, teaseAnimation.bounce);
>
> // Continue drag, make sure we don't create a gap on the left hand side
> - touchFlick(shell, units.gu(3), halfHeight, shell.width, halfHeight, false, false);
> + touchFlick(shell, units.gu(4), halfHeight, shell.width, halfHeight, false, false);
> verify(!teaseAnimation.running);
> compare(launcher.visibleWidth, launcher.panelWidth);
> compare(launcher.x, 0);
>
> Fixes "make testTutorial" for me

Added your patch.

« Back to merge proposal