Code review comment for lp:~dandrader/unity8/noStretchOnResize

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

> The last commit seems a okayish workaround to the problem. Let's go with this
> for now and refine it later.
>
> One tiny issue where I'd like to hear your input:
>
> Running on my laptop it sometimes happens that the dash doesn't start up
> properly (there's a bug for that, unrelated to this branch). With trunk, the
> window paints the background and then freezes. With this branch, the window
> doesn't even paint at all and we keep seeing the window decoration and shadow
> alone. What are your thoughts? Some potential issues?

This is not related to this branch but to its prerequisites in qtmir.
It's a workaround for the situation where a mir surface doesn't have buffers to draw. So instead of crashing we just give a null/empty texture to Qt Scenegraph.

« Back to merge proposal