Merge lp:~dandrader/unity8/noRotatingRectInMakeTry into lp:unity8
Proposed by
Daniel d'Andrada
| Status: | Merged |
|---|---|
| Approved by: | Mirco Müller |
| Approved revision: | 1690 |
| Merged at revision: | 1695 |
| Proposed branch: | lp:~dandrader/unity8/noRotatingRectInMakeTry |
| Merge into: | lp:unity8 |
| Diff against target: |
15 lines (+3/-1) 1 file modified
tests/utils/modules/Unity/Test/UnityTestCase.qml (+3/-1) |
| To merge this branch: | bzr merge lp:~dandrader/unity8/noRotatingRectInMakeTry |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
| Mirco Müller (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Don't show the rotating rect in "make tryFoo".
It's useless and distracting. Only show it when the qml test case is running
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable
* If you changed the UI, has there been a design review?
Not applicable
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Mirco Müller (macslow) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
* Did CI run pass? If not, please explain why.
No yet.
* Did you make sure that the branch does not contain spurious tags?
Yes.