Merge lp:~dandrader/unity8/noRotatingRectInMakeTry into lp:unity8

Proposed by Daniel d'Andrada
Status: Merged
Approved by: Mirco Müller
Approved revision: 1690
Merged at revision: 1695
Proposed branch: lp:~dandrader/unity8/noRotatingRectInMakeTry
Merge into: lp:unity8
Diff against target: 15 lines (+3/-1)
1 file modified
tests/utils/modules/Unity/Test/UnityTestCase.qml (+3/-1)
To merge this branch: bzr merge lp:~dandrader/unity8/noRotatingRectInMakeTry
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Mirco Müller (community) Approve
Review via email: mp+253513@code.launchpad.net

Commit message

Don't show the rotating rect in "make tryFoo".

It's useless and distracting. Only show it when the qml test case is running

Description of the change

* Are there any related MPs required for this MP to build/function as expected? Please list.
No

* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

* Did you make sure that your branch does not contain spurious tags?
Yes

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable

* If you changed the UI, has there been a design review?
Not applicable

To post a comment you must log in.
Revision history for this message
Mirco Müller (macslow) wrote :

* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

* Did CI run pass? If not, please explain why.
No yet.

* Did you make sure that the branch does not contain spurious tags?
Yes.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Mirco Müller (macslow) wrote :

* Did CI run pass? If not, please explain why.
No. Unrelated failures.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/utils/modules/Unity/Test/UnityTestCase.qml'
2--- tests/utils/modules/Unity/Test/UnityTestCase.qml 2015-03-18 10:18:45 +0000
3+++ tests/utils/modules/Unity/Test/UnityTestCase.qml 2015-03-19 13:58:16 +0000
4@@ -32,8 +32,10 @@
5 border { width: units.dp(1); color: "black" }
6 opacity: 0.6
7
8+ visible: testCase.running
9+
10 RotationAnimation on rotation {
11- running: true
12+ running: parent.visible
13 from: 0
14 to: 360
15 loops: Animation.Infinite

Subscribers

People subscribed via source and target branches