Code review comment for lp:~dandrader/unity8/mouseEdgePush

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

On 06/11/2015 09:48, Michael Zanetti wrote:
> + // to be overwritten by tests
> + property bool _containsMouse: root.containsMouse
>
> I'm starting to think you are mocking too much. Instead of all that logic with _containsMouse, wouldn't it be nicer to just use the standard containsMouse and in the test just do a mouseMove to fulfill that?

I've to mock this in order to *manually* test edge barriers. Can't do
otherwise. See EdgeBarrierControls. Run "make tryLauncher".

The automated tests do not overwrite this property and do the
mouseMove() just like you mentioned.

« Back to merge proposal