Code review comment for lp:~dandrader/unity8/lifecycle

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

> plugins/Unity/Launcher/CMakeLists.txt still requires unity-shell-application=1
> while the other places want unity-shell-application=3.
>
> Besides wondering why that even works (shouldn't =1 fail now that we have 3
> installed?) I'm also wondering if this what we want.

I think CMake might be caching the output of the first ever call to find_package() for a certain package, so it passes the first check and just ignores the next one.

No, they should all be the same.

« Back to merge proposal